Update secret loading logic#7
Merged
Merged
Conversation
…configuration **Core Changes:** - **New architecture**: Replaced hardcoded `USE_SECRETS` modifications with dynamic configuration reading from `values-global.yaml` - **Single source of truth**: Added `global.secretLoader.disabled` field that controls secrets behavior (true = disabled, false = enabled) - **Makefile restructure**: Now generates simple include-based `Makefile` + always copies `Makefile-pattern` with dynamic logic - **Runtime configuration**: `Makefile-pattern` uses `yq` to read `global.secretLoader.disabled` and set `USE_SECRETS` accordingly **Implementation Details:** - Updated `ProcessGlobalValues()` to accept `withSecrets` parameter and set `global.secretLoader.disabled` field - Modified Makefile generation to create include-based structure instead of copying/modifying single file - Removed static file modifications from `pattern.sh` and `HandleSecretsSetup()` - Updated all unit and integration tests to validate new `global.secretLoader.disabled` behavior - Added Cursor acknowledgment to README and updated documentation **Benefits:** - Cleaner architecture with configuration-driven behavior - Users can customize Makefiles while retaining common functionality - Eliminates need for static file modifications - Single configuration field controls all secrets-related behavior The change maintains full backward compatibility while providing a more robust and maintainable architecture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.