Skip to content

Increase unit tests coverage #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbaldessari merged 2 commits into from
Jun 24, 2026
Merged

Increase unit tests coverage #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2465818
Increase unit test coverage
mbaldessari Jun 24, 2026
c6d69b1
Increase unit test coverage for multiple managedclustergroups
mbaldessari Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
246 changes: 246 additions & 0 deletions tests/application_policy_edge_cases_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,246 @@
suite: Test application-policies edge cases
templates:
- templates/policies/application-policies.yaml
release:
name: release-test
tests:
- it: should use vpArgoNamespace as destination namespace when singleArgoCD is true
values:
- ./clusterselector_values.yaml
set:
global:
singleArgoCD: true
vpArgoNamespace: custom-argocd
multiSourceSupport: true
multiSourceRepoUrl: "https://charts.example.com"
multiSourceTargetRevision: "0.1.0"
asserts:
- documentSelector:
path: metadata.name
value: group-one-clustergroup-policy
equal:
path: spec.policy-templates[0].objectDefinition.spec.object-templates[1].objectDefinition.spec.destination.namespace
value: custom-argocd

- it: should use pattern-name namespace as destination when singleArgoCD is false
values:
- ./clusterselector_values.yaml
set:
global:
singleArgoCD: false
pattern: multicloud-gitops
multiSourceSupport: true
multiSourceRepoUrl: "https://charts.example.com"
multiSourceTargetRevision: "0.1.0"
asserts:
- documentSelector:
path: metadata.name
value: group-one-clustergroup-policy
equal:
path: spec.policy-templates[0].objectDefinition.spec.object-templates[1].objectDefinition.spec.destination.namespace
value: multicloud-gitops-group-one

- it: should include helmOverrides in non-multisource mode
values:
- ./clusterselector_values.yaml
asserts:
- documentSelector:
path: metadata.name
value: group-one-clustergroup-policy
contains:
path: spec.policy-templates[0].objectDefinition.spec.object-templates[1].objectDefinition.spec.source.helm.parameters
content:
name: clusterGroup.isHubCluster
value: "false"

- it: should use per-group repoURL when specified
values:
- ./clusterselector_values.yaml
set:
clusterGroup:
managedClusterGroups:
exampleRegion:
name: group-one
repoURL: https://github.com/custom/repo
acmlabels:
- name: clusterGroup
value: group-one
helmOverrides:
- name: clusterGroup.isHubCluster
value: false
asserts:
- documentSelector:
path: metadata.name
value: group-one-clustergroup-policy
equal:
path: spec.policy-templates[0].objectDefinition.spec.object-templates[1].objectDefinition.spec.source.repoURL
value: https://github.com/custom/repo

- it: should set prune to true when deletePattern is not none
values:
- ./clusterselector_values.yaml
set:
global:
deletePattern: DeleteChildApps
multiSourceSupport: true
multiSourceRepoUrl: "https://charts.example.com"
multiSourceTargetRevision: "0.1.0"
asserts:
- documentSelector:
path: metadata.name
value: group-one-clustergroup-policy
equal:
path: spec.policy-templates[0].objectDefinition.spec.object-templates[1].objectDefinition.spec.syncPolicy.automated.prune
value: true

- it: should set prune to false when deletePattern is none
values:
- ./clusterselector_values.yaml
set:
global:
deletePattern: none
multiSourceSupport: true
multiSourceRepoUrl: "https://charts.example.com"
multiSourceTargetRevision: "0.1.0"
asserts:
- documentSelector:
path: metadata.name
value: group-one-clustergroup-policy
equal:
path: spec.policy-templates[0].objectDefinition.spec.object-templates[1].objectDefinition.spec.syncPolicy.automated.prune
value: false

- it: should set pruneObjectBehavior when deletePattern is DeleteChildApps
values:
- ./clusterselector_values.yaml
set:
global:
deletePattern: DeleteChildApps
multiSourceSupport: true
multiSourceRepoUrl: "https://charts.example.com"
multiSourceTargetRevision: "0.1.0"
asserts:
- documentSelector:
path: metadata.name
value: group-one-clustergroup-policy
equal:
path: spec.policy-templates[0].objectDefinition.spec.pruneObjectBehavior
value: DeleteIfCreated

- it: should use custom applicationRetryLimit
values:
- ./clusterselector_values.yaml
set:
global:
options:
applicationRetryLimit: 5
multiSourceSupport: true
multiSourceRepoUrl: "https://charts.example.com"
multiSourceTargetRevision: "0.1.0"
asserts:
- documentSelector:
path: metadata.name
value: group-one-clustergroup-policy
equal:
path: spec.policy-templates[0].objectDefinition.spec.object-templates[1].objectDefinition.spec.syncPolicy.retry.limit
value: 5

- it: should render separate resources for multiple managedClusterGroups
set:
global:
multiSourceSupport: true
multiSourceRepoUrl: "https://charts.example.com"
multiSourceTargetRevision: "0.1.0"
clusterGroup:
managedClusterGroups:
groupOne:
name: east
acmlabels:
- name: clusterGroup
value: east
helmOverrides:
- name: clusterGroup.isHubCluster
value: false
groupTwo:
name: west
acmlabels:
- name: clusterGroup
value: west
helmOverrides:
- name: clusterGroup.isHubCluster
value: false
asserts:
- hasDocuments:
count: 6
- documentSelector:
path: metadata.name
value: east-clustergroup-policy
isKind:
of: Policy
- documentSelector:
path: metadata.name
value: west-clustergroup-policy
isKind:
of: Policy
- documentSelector:
path: metadata.name
value: east-placement-binding
isKind:
of: PlacementBinding
- documentSelector:
path: metadata.name
value: west-placement-binding
isKind:
of: PlacementBinding
- documentSelector:
path: metadata.name
value: east-placement
isKind:
of: Placement
- documentSelector:
path: metadata.name
value: west-placement
isKind:
of: Placement

- it: should set correct clusterGroup.name per group in multiple managedClusterGroups
set:
global:
multiSourceSupport: true
multiSourceRepoUrl: "https://charts.example.com"
multiSourceTargetRevision: "0.1.0"
clusterGroup:
managedClusterGroups:
groupOne:
name: east
acmlabels:
- name: clusterGroup
value: east
helmOverrides:
- name: clusterGroup.isHubCluster
value: false
groupTwo:
name: west
acmlabels:
- name: clusterGroup
value: west
helmOverrides:
- name: clusterGroup.isHubCluster
value: false
asserts:
- documentSelector:
path: metadata.name
value: east-clustergroup-policy
contains:
path: spec.policy-templates[0].objectDefinition.spec.object-templates[1].objectDefinition.spec.sources[1].helm.parameters
content:
name: clusterGroup.name
value: east
- documentSelector:
path: metadata.name
value: west-clustergroup-policy
contains:
path: spec.policy-templates[0].objectDefinition.spec.object-templates[1].objectDefinition.spec.sources[1].helm.parameters
content:
name: clusterGroup.name
value: west
Loading