Update lark-parser to lark #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lark-parser has been renamed to lark. The newest release seems to be compatible with commentjson's code and all tests pass, so just update the requirement. Closes vaidik#51
|
@vaidik Any plan to merge this upstream and have a new release of |
|
Also bumped into this problem of old dependencies. @vaidik can you please clarify the project's status? |
asherf
added a commit
to asherf/skyvern
that referenced
this pull request
Jun 11, 2025
also applied vaidik/commentjson#52 and added type annotations This gets rid of the deprecation we see in pytest: https://github.com/Skyvern-AI/skyvern/actions/runs/15564515234/job/43825105717#step:12:31-36 ``` .venv/lib/python3.11/site-packages/ddtrace/internal/module.py:295 /home/runner/work/skyvern/skyvern/.venv/lib/python3.11/site-packages/ddtrace/internal/module.py:295: DeprecationWarning: module 'sre_parse' is deprecated self.loader.exec_module(module) .venv/lib/python3.11/site-packages/ddtrace/internal/module.py:295 /home/runner/work/skyvern/skyvern/.venv/lib/python3.11/site-packages/ddtrace/internal/module.py:295: DeprecationWarning: module 'sre_constants' is deprecated self.loader.exec_module(module) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lark-parser has been renamed to lark. The newest release seems
to be compatible with commentjson's code and all tests pass, so just
update the requirement.
Closes #51