fix: revert update/field-number#90
Conversation
staheri14
left a comment
staheri14
left a comment
There was a problem hiding this comment.
The changes look fine and reasonable to me, However as I haven't been involved in this codebase (and need onboard myself) I am adding @oskarth as the reviewer as well.
The mvds protocol is in the stable mode, and the current set of changes are not backward compatible, I am wondering how should we proceed with it @oskarth? any changelog?
Given this comment of @cammellos #89 (comment) it seems updating field numbers should not cause any issue.
oskarth
left a comment
oskarth
left a comment
There was a problem hiding this comment.
LGTM, thanks! Would you mind pushing a PR to update the spec too?
Yeah, we could probably make an exception because the stable implementation (Status app) actually used an earlier version, so the previous spec lifecycle change was incorrect. |
3 participants
Reverts #75
Fixes #89