test: add integration tests for chat history feature#8874
Open
ugur-vaadin wants to merge 2 commits intomainfrom
Open
test: add integration tests for chat history feature#8874ugur-vaadin wants to merge 2 commits intomainfrom
ugur-vaadin wants to merge 2 commits intomainfrom
Conversation
tomivirkki
reviewed
Mar 10, 2026
...egration-tests/src/test/java/com/vaadin/flow/component/ai/tests/AIOrchestratorHistoryIT.java
Outdated
Show resolved
Hide resolved
|
tomivirkki
approved these changes
Mar 12, 2026
| var savedHistory = (List<ChatMessage>) VaadinSession.getCurrent() | ||
| .getAttribute(HISTORY_SESSION_KEY); | ||
| if (savedHistory != null) { | ||
| builder.withHistory(savedHistory, Collections.emptyMap()); |
Member
There was a problem hiding this comment.
Instead of Collections.emptyMap() (= not restoring attachments with the history), also store the attachmentStorage to VaadinSession so they get restored on refresh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds integration tests for the AI Orchestrator chat history support.
No related issue.
Type of change
Checklist