Skip to content

chore: Upgrade supported Node.js to 20#4257

Closed
mshabarov wants to merge 2 commits into
v24from
upgrade-node-minimal
Closed

chore: Upgrade supported Node.js to 20#4257
mshabarov wants to merge 2 commits into
v24from
upgrade-node-minimal

Conversation

@mshabarov
Copy link
Copy Markdown
Contributor

Node.js goes out of support and React 19 needs Node.js 20+

Node.js goes out of support and React 19 needs Node.js 20+
| Java| 17 or later
| Spring Boot| 3.0 or later
| Node.js| 18 or later
| Node.js| 20 or later
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a 24.0 list and now you are changing only one part of it but still linking to 24.0.0 release notes above. It should be made clearer that this is for the latest minor of Vaadin 24, link to that and also update all the other rows from 24.7.0 release notes

@peholmst
Copy link
Copy Markdown
Member

peholmst commented Aug 8, 2025

Is this PR still relevant?

@mshabarov
Copy link
Copy Markdown
Contributor Author

Yes, still relevant, Vaadin 24.7+ (latest supported minor versions) are all have Node.js 20 as a minimum supported. It was abandoned by me in favour of other tasks, but need still to figure out how this article is aligned with the release notes and how to address Artur's comment above.

@peholmst
Copy link
Copy Markdown
Member

peholmst commented Aug 8, 2025

@mshabarov Understood. If you want this change to show up in the main branch as well (currently used for V25), add the target/main label to the PR. It will be automatically cherry-picked after merging.

@mshabarov
Copy link
Copy Markdown
Contributor Author

Yes, I don't even remember why haven't I chosen the main branch from the beginning.

@mshabarov mshabarov added the target/main cherry pick to main branch label Aug 8, 2025
@peholmst
Copy link
Copy Markdown
Member

peholmst commented Aug 8, 2025

@mshabarov Probably because the main branch was created yesterday 😄 .

@peholmst peholmst requested a review from Artur- August 18, 2025 07:30
@peholmst
Copy link
Copy Markdown
Member

These changes have already been applied in another PR, closing.

@peholmst peholmst closed this Aug 26, 2025
@peholmst peholmst deleted the upgrade-node-minimal branch August 26, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

target/main cherry pick to main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants