feat(hostname): add benchmark with large /etc/hosts#10979
Open
naoNao89 wants to merge 1 commit intouutils:mainfrom
Open
feat(hostname): add benchmark with large /etc/hosts#10979naoNao89 wants to merge 1 commit intouutils:mainfrom
naoNao89 wants to merge 1 commit intouutils:mainfrom
Conversation
sylvestre
reviewed
Feb 16, 2026
| /// This benchmarks the underlying DNS lookup without the full hostname command overhead | ||
| #[cfg(not(any(target_os = "freebsd", target_os = "openbsd")))] | ||
| #[divan::bench( | ||
| args = [1_000, 10_000, 100_000], |
Contributor
There was a problem hiding this comment.
just pass one value
it isn't interesting to have several
sylvestre
reviewed
Feb 16, 2026
| /// To test with the generated large hosts file, run with NSS_WRAPPER: | ||
| /// `LD_PRELOAD=/usr/lib/libnss_wrapper.so NSS_WRAPPER_HOSTS=/path/to/hosts cargo bench` | ||
| #[divan::bench( | ||
| args = [1_000, 10_000, 100_000], |
|
GNU testsuite comparison: |
naoNao89
force-pushed
the
feature/hostname-benchmark-10949
branch
from
5098b5e to
b63fc94
Compare
Contributor
|
please keep only 2 or 3 benchmarks. we don't need that many |
Contributor
Author
|
hmm keep only 3:
|
naoNao89
force-pushed
the
feature/hostname-benchmark-10949
branch
2 times, most recently
from
653b942 to
8a43ab6
Compare
Adds comprehensive benchmarks for the hostname utility, including: - Realistic hosts file generation with various hostname patterns - Benchmarks for all flags: -s, -d, -f, -i - Parameterized tests with 1K, 10K, 100K entries - NSS_WRAPPER support for testing with generated hosts files - CI integration for automated benchmark tracking Fixes uutils#10949
naoNao89
force-pushed
the
feature/hostname-benchmark-10949
branch
from
8a43ab6 to
087ccf0
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add benchmarks for hostname utility with large hosts files.
Tests all flags (-s, -d, -f, -i) with 1K/10K/100K entries (includes NSS_WRAPPER support for testing generated hosts files)
Closes #10949