chore: 운영 환경 PostgreSQL 컨테이너 제거 및 외부 DB 연결 설정 보완#139
Merged
Conversation
📝 WalkthroughWalkthrough이 PR은 프로덕션 DB/모니터링 구성과 CI 검증을 Redis 인증·exporter 중심으로 재구성하고, Mongock 기반 MongoDB 마이그레이션(메시지 인덱스 추가), 관련 테스트·문서·테스트컨테이너 이미지 업데이트를 포함합니다. ChangesProduction Database Hardening and Migrations
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/main/resources/application-prod.yaml (1)
34-37:⚠️ Potential issue | 🟠 Major | ⚡ Quick win
spring.jpa.open-in-view=false설정이 누락되었습니다.운영 프로파일에서
spring.jpa.open-in-view가 명시되지 않아 가이드라인을 충족하지 못합니다. 명시적으로false를 추가해 주세요.🔧 제안 수정안
spring: jpa: + open-in-view: false hibernate: ddl-auto: validateAs per coding guidelines,
src/main/resources/application*.yaml: Keepspring.jpa.open-in-view=falseconfiguration setting.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/resources/application-prod.yaml` around lines 34 - 37, The production YAML is missing the spring.jpa.open-in-view setting; update src/main/resources/application-prod.yaml to explicitly add spring.jpa.open-in-view: false under the spring.jpa configuration (alongside jpa.hibernate.ddl-auto: validate) so the production profile enforces open-in-view=false as required by the guidelines.Source: Coding guidelines
.github/workflows/deploy-db.yml (1)
53-59:⚠️ Potential issue | 🟠 Major | ⚡ Quick win필수 DB/Mongo 접속 변수 검증을 함께 추가해 주세요.
지금 검증은 포트와
REDIS_PASSWORD중심이라,DB_HOST/DB_NAME/DB_USER/DB_PASSWORD또는 Mongo 필수값이 비어 있어도 배포 단계에서 늦게 실패할 수 있습니다. Validate 단계에서 미리 차단하는 편이 안전합니다.🔧 제안 수정안
grep '^DB_PRIVATE_IP=' .env.db + grep '^DB_HOST=.' .env.db + grep '^DB_NAME=.' .env.db + grep '^DB_USER=.' .env.db + grep '^DB_PASSWORD=.' .env.db + grep '^MONGO_USER=.' .env.db + grep '^MONGO_PASSWORD=.' .env.db + grep '^MONGO_DB=.' .env.db grep '^POSTGRES_EXPORTER_PORT=' .env.db grep '^REDIS_EXPORTER_PORT=' .env.db grep '^MONGODB_EXPORTER_PORT=' .env.db grep '^REDIS_PASSWORD=.' .env.db🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/deploy-db.yml around lines 53 - 59, Add mandatory env-variable checks to the workflow: extend the existing grep validation block (the lines that currently check DB_PRIVATE_IP, POSTGRES_EXPORTER_PORT, REDIS_EXPORTER_PORT, MONGODB_EXPORTER_PORT, REDIS_PASSWORD) to also assert non-empty DB_HOST, DB_NAME, DB_USER, DB_PASSWORD and the required Mongo vars (e.g. MONGO_HOST, MONGO_DB, MONGO_USER, MONGO_PASSWORD or whatever keys your app uses). Ensure each grep uses a pattern like '^VAR_NAME=.' and that the script exits non‑zero on failure so docker compose validation doesn't run with missing DB/Mongo credentials. Include clear names of the variables in the checks to surface missing settings early.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@infra/monitoring/README.md`:
- Around line 71-72: The DB server components list is missing postgres-exporter
which conflicts with other sections; update the DB 서버 운영 compose description to
include "postgres-exporter" alongside redis-exporter, mongodb-exporter, and
node-exporter, and ensure the README's service list, the POSTGRES_EXPORTER_PORT
reference, and the target example (target 예시) all consistently reflect the
postgres-exporter service name and port so the documentation matches the actual
monitoring targets.
---
Outside diff comments:
In @.github/workflows/deploy-db.yml:
- Around line 53-59: Add mandatory env-variable checks to the workflow: extend
the existing grep validation block (the lines that currently check
DB_PRIVATE_IP, POSTGRES_EXPORTER_PORT, REDIS_EXPORTER_PORT,
MONGODB_EXPORTER_PORT, REDIS_PASSWORD) to also assert non-empty DB_HOST,
DB_NAME, DB_USER, DB_PASSWORD and the required Mongo vars (e.g. MONGO_HOST,
MONGO_DB, MONGO_USER, MONGO_PASSWORD or whatever keys your app uses). Ensure
each grep uses a pattern like '^VAR_NAME=.' and that the script exits non‑zero
on failure so docker compose validation doesn't run with missing DB/Mongo
credentials. Include clear names of the variables in the checks to surface
missing settings early.
In `@src/main/resources/application-prod.yaml`:
- Around line 34-37: The production YAML is missing the spring.jpa.open-in-view
setting; update src/main/resources/application-prod.yaml to explicitly add
spring.jpa.open-in-view: false under the spring.jpa configuration (alongside
jpa.hibernate.ddl-auto: validate) so the production profile enforces
open-in-view=false as required by the guidelines.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: cec519a9-6400-4237-9cfb-4121e25ecf14
📒 Files selected for processing (10)
.claude/skills/review-code-against-docs/SKILL.md.env.db.example.github/workflows/deploy-compose.yml.github/workflows/deploy-db.ymlCONTRIBUTING.mdcompose.db.prod.yamlinfra/caddy/Caddyfileinfra/monitoring/README.mdsrc/main/resources/application-prod.yamlsrc/test/java/com/howaboutus/backend/common/config/ProdDatabaseConfigTest.java
minbros
temporarily deployed
to
production-monitoring
GitHub Actions
Inactive
- pg_isready 명령어에 -h localhost -p 5432를 추가하여 TCP 5432 포트 바인딩 완료 여부까지 검증하도록 개선 - 설계 사양서(spec) 및 구현 계획서(plan) 추가
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/main/java/com/howaboutus/backend/messages/document/ChatMessage.java (1)
18-23:⚠️ Potential issue | 🟡 MinorSpring Data 자동 인덱스 생성 가이드라인 정리 권장
ChatMessage의@CompoundIndexes는CreateMessageIndexesChangeUnit에서 동일 인덱스를 명시적으로 생성하는 구조와 중복됩니다.application*.yaml에spring.data.mongodb.auto-index-creation을 켜는 설정은 없고, Spring Boot 4.0.5 기본값은false라 자동 인덱스 생성 충돌 가능성은 낮습니다.- 그래도 기본값에 의존하지 않으려면
spring.data.mongodb.auto-index-creation: false를 명시하거나(가이드라인 준수), 인덱스 중복/오해를 줄이기 위해@CompoundIndexes를 제거하는 쪽으로 정리하는 것을 권장합니다.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/com/howaboutus/backend/messages/document/ChatMessage.java` around lines 18 - 23, The ChatMessage class currently declares `@CompoundIndexes` which duplicates the explicit index creation in CreateMessageIndexesChangeUnit; to avoid confusion and potential conflicts, either remove the `@CompoundIndexes` annotation from the ChatMessage entity (preferred to keep indexing centralized in CreateMessageIndexesChangeUnit) or explicitly disable auto index creation by adding spring.data.mongodb.auto-index-creation: false to application*.yaml; locate the ChatMessage class and the `@CompoundIndexes` block to delete it if removing, or update the application configuration to set the property if you choose to keep the annotation.Source: Coding guidelines
🧹 Nitpick comments (1)
src/test/java/com/howaboutus/backend/common/migration/MongoMessageIndexMigrationTest.java (1)
23-42: ⚡ Quick win마이그레이션 멱등성(idempotency) 테스트를 추가하는 것을 권장합니다.
현재 테스트는 빈 MongoDB에서 인덱스 생성을 검증하지만, 마이그레이션을 두 번 실행했을 때 에러 없이 성공하는지(멱등성)도 검증하면 더욱 견고합니다. Mongock은 이미 실행된 ChangeUnit을 추적하므로 중복 실행을 방지하지만, 이를 명시적으로 테스트하면 신뢰성이 높아집니다.
🧪 멱등성 테스트 예시
`@Test` `@DisplayName`("Mongock 마이그레이션은 멱등성을 보장한다 (중복 실행 시 에러 없음)") void mongockMigrationIsIdempotent() { // Given: 이미 인덱스가 생성된 상태 assertThat(mongoTemplate.collectionExists("messages")).isTrue(); // When: 마이그레이션을 다시 실행 시도 (실제로는 Mongock이 스킵하지만 검증 차원) // Mongock은 이미 실행된 ChangeUnit을 다시 실행하지 않으므로 // 여기서는 인덱스가 이미 존재하는 상태에서 createIndex를 호출해도 에러가 없음을 확인 // Then: 인덱스가 여전히 정상적으로 존재 Map<String, Document> indexesByName = mongoTemplate.getCollection("messages") .listIndexes() .into(new ArrayList<>()) .stream() .collect(Collectors.toMap(index -> index.getString("name"), Function.identity())); assertThat(indexesByName).hasSize(5); // _id 포함 5개 }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/test/java/com/howaboutus/backend/common/migration/MongoMessageIndexMigrationTest.java` around lines 23 - 42, Add an idempotency test to MongoMessageIndexMigrationTest named mongockMigrationIsIdempotent that ensures re-running the migration (or invoking the same index-creation logic again) does not fail and leaves indexes intact: set up/verify the "messages" collection exists, re-execute the migration path (or directly call the index-creation routine in the migration class), collect indexes via the same getCollection(...).listIndexes().into(...).stream()... pattern used in mongockCreatesMessageIndexesOnEmptyMongo, and assert the expected number/names of indexes (e.g., include _id so total size is 5) and that existing indexes remain unchanged. Use the same helper/assertIndex logic and reference MongoMessageIndexMigrationTest and the new method mongockMigrationIsIdempotent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/main/java/com/howaboutus/backend/messages/document/ChatMessage.java`:
- Around line 18-23: The ChatMessage class currently declares `@CompoundIndexes`
which duplicates the explicit index creation in CreateMessageIndexesChangeUnit;
to avoid confusion and potential conflicts, either remove the `@CompoundIndexes`
annotation from the ChatMessage entity (preferred to keep indexing centralized
in CreateMessageIndexesChangeUnit) or explicitly disable auto index creation by
adding spring.data.mongodb.auto-index-creation: false to application*.yaml;
locate the ChatMessage class and the `@CompoundIndexes` block to delete it if
removing, or update the application configuration to set the property if you
choose to keep the annotation.
---
Nitpick comments:
In
`@src/test/java/com/howaboutus/backend/common/migration/MongoMessageIndexMigrationTest.java`:
- Around line 23-42: Add an idempotency test to MongoMessageIndexMigrationTest
named mongockMigrationIsIdempotent that ensures re-running the migration (or
invoking the same index-creation logic again) does not fail and leaves indexes
intact: set up/verify the "messages" collection exists, re-execute the migration
path (or directly call the index-creation routine in the migration class),
collect indexes via the same
getCollection(...).listIndexes().into(...).stream()... pattern used in
mongockCreatesMessageIndexesOnEmptyMongo, and assert the expected number/names
of indexes (e.g., include _id so total size is 5) and that existing indexes
remain unchanged. Use the same helper/assertIndex logic and reference
MongoMessageIndexMigrationTest and the new method mongockMigrationIsIdempotent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a55de585-db76-4110-8099-1425276cebef
📒 Files selected for processing (16)
AGENTS.mdREADME.mdbuild.gradlecompose.db.dev.yamlcompose.db.prod.yamldocs/ai/erd.mddocs/superpowers/plans/2026-06-08-postgresql-docker-healthcheck.mddocs/superpowers/plans/2026-06-08-remove-postgis.mddocs/superpowers/specs/2026-06-08-postgresql-docker-healthcheck-design.mddocs/superpowers/specs/2026-06-08-remove-postgis-design.mdscripts/mongo/backfill-message-sequence.jssrc/main/java/com/howaboutus/backend/common/config/MongoMigrationConfig.javasrc/main/java/com/howaboutus/backend/common/migration/mongo/CreateMessageIndexesChangeUnit.javasrc/main/java/com/howaboutus/backend/messages/document/ChatMessage.javasrc/test/java/com/howaboutus/backend/common/migration/MongoMessageIndexMigrationTest.javasrc/test/java/com/howaboutus/backend/support/BaseIntegrationTest.java
💤 Files with no reviewable changes (1)
- scripts/mongo/backfill-message-sequence.js
✅ Files skipped from review due to trivial changes (3)
- README.md
- docs/superpowers/specs/2026-06-08-postgresql-docker-healthcheck-design.md
- docs/superpowers/specs/2026-06-08-remove-postgis-design.md
🚧 Files skipped from review as they are similar to previous changes (1)
- compose.db.prod.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 내용
compose.db.prod.yaml에서 로컬postgres서비스를 제거하고, 외부 PostgreSQL 인프라(AWS Lightsail Managed DB)에 연결할 수 있도록 설정을 조정했습니다.postgres-exporter및redis-exporter의 데이터 소스 연결 설정에 인증 정보와 SSL 설정을 반영했습니다.redis서비스에 패스워드 설정(--requirepass), 메모리 제한 설정(--maxmemory), 비영속 정책(--save "" --appendonly no)을 반영했습니다.src/main/resources/application-prod.yaml에 외부 DB 접속을 위한 세부 타임아웃 파라미터(PostgreSQL, MongoDB) 및 HikariCP 설정(connection-timeout, validation-timeout, pool-size 등), Redis 패스워드/데이터베이스 세부 설정을 적용했습니다.ProdDatabaseConfigTest.java테스트 코드를 추가/수정하여 운영 환경의 DB 연결 사양을 검증할 수 있도록 조치했습니다.CONTRIBUTING.md에 PR 대상 브랜치 명세를 명확히 하고,infra/monitoring/README.md에 DB 서버 운영 구성 요소를 최신화했습니다.변경 이유
테스트
./gradlew build/review-code-against-docs스킬로 검증체크리스트
하네스 변경 체크리스트
Summary by CodeRabbit
새 기능
개선 사항
테스트
문서