feat: virtualise Findings, Scans, Reports#488
Open
khat190 wants to merge 1 commit into
Open
Conversation
utksh1
requested changes
Jun 4, 2026
Owner
utksh1
left a comment
There was a problem hiding this comment.
Thanks for the performance work. This PR currently has merge conflicts (DIRTY / conflicting), so I cannot do a reliable code review or merge it yet.
Please rebase/update the branch against current main, resolve the conflicts in Findings/Scans/Reports and package files, then make sure the frontend checks pass. After that I will review the virtualization behavior and merge if it is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR virtualizes the Findings, Scans, and Reports pages using
@tanstack/react-virtualso we no longer render every item in large lists.Changes made
Findings.tsx
ArrowUp/ArrowDown)Scans.tsx
Reports.tsx
src/hooks/useVirtualList.ts
useVirtualizerfor future pagesWhy
The Findings and Scans pages become noticeably slow when there are hundreds of records because every item is rendered at once. With larger datasets this leads to unnecessary DOM nodes and poor scrolling performance.
Virtualization keeps only the visible rows mounted, which significantly improves responsiveness and memory usage on large datasets.
Fixes #234.
How to test
cd frontend npm installOpen the Findings, Scans, and Reports pages and verify:
Run the tests:
Expected result: all 32 tests pass.
Trade-offs
Related issue
Closes #234