feat: implement scheduled recurring scans with blackout windows (#253)#482
Open
YerraguntaAjayKumar wants to merge 1 commit into
Open
feat: implement scheduled recurring scans with blackout windows (#253)#482YerraguntaAjayKumar wants to merge 1 commit into
YerraguntaAjayKumar wants to merge 1 commit into
Conversation
a691ba2 to
8069213
Compare
…h1#253) - Add croniter-based cron parser with timezone support (zoneinfo) - Implement blackout window interceptor for maintenance windows - Add missed-run recovery policy for system resilience - Create React ScanScheduleForm component with validation - Add comprehensive test coverage (19 backend, 40+ frontend tests) - Validate cron syntax and time formats on both client and server Closes utksh1#253
8069213 to
6a3912d
Compare
Author
|
Hi @utksh1, the implementation is complete and all CI/CD checks are green! It is ready for your review whenever you have a moment. Let me know if you'd like any adjustments to the blackout window logic or the frontend React components |
utksh1
requested changes
Jun 4, 2026
Owner
utksh1
left a comment
There was a problem hiding this comment.
Thanks for the work here. I cannot merge this in its current shape because the feature is mostly standalone and not integrated into the existing SecuScan scheduling flow.
Required changes:
- Wire the scheduling model/API/UI into the existing scan/workflow creation path so users can actually create, list, update, and execute recurring scans from the app.
- Convert the frontend work to the repo conventions (
.tsx, existing styling/layout patterns, existing test location/naming). The current new JSX/CSS module component sits outside the current UI system and is not reachable. - Avoid adding a parallel scheduler utility that duplicates existing scheduler/workflow behavior unless it is explicitly integrated with the production scheduler.
- Make the missed-run recovery logic deterministic/testable; the current tests mostly assert return types because the code calls wall-clock
datetime.now()directly.
Once this is wired into the real product path and covered with meaningful integration tests, I can re-review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented a cron-like scheduling service to automate recurring scans. This includes a robust
croniter-based parser withzoneinfotimezone handling, an interceptor to evaluate blackout windows (including overnight shifts), and a conservative missed-run recovery policy to safely handle system downtime. Additionally, built a responsive React UI (ScanScheduleForm) with strict client-side validation enforcing 5-part cron syntax.Related Issues
Fixes #253
Type of Change
How Has This Been Tested?
./testing/test_scheduler.py), verifying all 19 tests pass for timezone boundaries, blackout skips, missed-run recovery, and disabled schedules.ScanScheduleForm.test.jsx.Checklist