fix(frontend): clear request timeout on failed requests#481
Merged
Conversation
6ebd132 to
4302449
Compare
utksh1
approved these changes
Jun 4, 2026
Owner
utksh1
left a comment
There was a problem hiding this comment.
Looks good. The request helper now clears the timeout in a finally block, and the rejection/abort cleanup paths are covered by focused frontend tests. CI is passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moved request timeout cleanup in frontend/src/api.ts into a finally block so timers are cleared for all request paths, including rejected and aborted requests.
Also added focused unit tests covering:
rejected fetch requests
aborted requests
This preserves the existing abort behavior while ensuring timeout cleanup always occurs.
Related Issues
Closes #465
Type of Change
How Has This Been Tested?
npm run test -- api.auth
Result:
15 tests passed
Checklist