Remove commented-out auth login checks from autocomplete logic#7
Open
usqr wants to merge 4 commits into
Open
Conversation
The Precog rebrand commit (03ab966) accidentally deleted the root .gitignore, leaving node_modules/, target/, dist/ and other build artifacts untracked-but-not-ignored. Restore the upstream ignore set.
Three commented-out fig_request::fig_auth::is_logged_in() references in fig_desktop pointed at a crate removed during the auth-removal work.
…-continuation-KfQIf # Conflicts: # .gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes commented-out authentication checks that were previously gating autocomplete functionality. These checks are no longer needed as part of the auth removal effort.
Changes
fig_request::fig_auth::is_logged_in()checks from autocomplete enable logic (lines 511 and 525)fig_request::fig_auth::is_logged_in()check from autocomplete enable logic (line 517)fig_desktopGTK/webkit dependenciesImplementation Details
The autocomplete enable conditions now rely solely on:
autocomplete.disablesettings flagThe removal of these commented-out auth checks completes the login gate removal from the autocomplete feature, allowing it to function without authentication requirements.
https://claude.ai/code/session_01DTdpq5f5q6hNkwAyJLpd7e