Skip to content

Fix: an exception when Client.stop_listening is called but the future is None #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moha-abdi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: an exception when Client.stop_listening is called but the future is None #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pyromod/listen/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,8 @@ async def stop_listening(
async def stop_listener(self, listener: Listener):
self.remove_listener(listener)

if listener.future.done():
# we have to check if listener.future is not None [incase of Client.next_step_handler is used this will be None]
if listner.future is not None and listener.future.done():
return

if callable(config.stopped_handler):
Expand All @@ -204,7 +205,8 @@ async def stop_listener(self, listener: Listener):
None, config.stopped_handler, None, listener
)
elif config.throw_exceptions:
listener.future.set_exception(ListenerStopped())
if listener.future is not None:
listener.future.set_exception(ListenerStopped())

@should_patch()
def register_next_step_handler(
Expand Down