Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55457a493b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if self.settings_dialog.isVisible(): | ||
| self.settings_dialog.hide() |
There was a problem hiding this comment.
Restore settings dialog after window is unminimized
When the main window is minimized, changeEvent forcibly calls self.settings_dialog.hide(), but unlike the control panel there is no state tracking to restore it; because _show_settings opens this dialog with exec(), minimizing while settings are open can terminate that modal session and drop the user's in-progress edits after restore. This affects users who open Settings, adjust values, then minimize the app before applying.
Useful? React with 👍 / 👎.
Motivation
AudioLinesidle animation when no music is playing so it does not animate while silent.Description
src/ui/main_window.py(ControlPanel(self),changeEvent,moveEvent,resizeEvent, and_position_control_panel).SpectrumBarsvisual weight insrc/styles/spectrum_bars.pyby changingself.num_barsto72, reducingself.bar_spacingto2, raising the baseline (baseline_y) and increasing bar/peak height calculations to fill more vertical space.Waveformvertical occupancy insrc/styles/waveform.pyby raisingamplitudeand sample scaling so the waveform fills more of the canvas.AudioLinesquiet when there is no audio by introducingidle_energy_floorand gating idle motion/time advancement, and increase layer spacing/reactivity for larger presence insrc/styles/audio_lines.py.python -m compileall srcand targeted compilation of changed files.Testing
python -m compileall srcwhich succeeded and showed updated modules compiled without syntax errors.python -m compileall src/ui/main_window.py src/styles/spectrum_bars.py src/styles/audio_lines.py src/styles/waveform.pywhich succeeded for the changed files.pytest -qbut test collection failed due to missing environment dependencies in this environment (ModuleNotFoundError: No module named 'numpy'andNo module named 'sounddevice'), so unit tests could not complete here.Codex Task