This repository was archived by the owner on Mar 29, 2022. It is now read-only.
remove_vehicle function in services/director.py#189
Open
tanishqjasoria wants to merge 5 commits intouptane:developfrom
Open
remove_vehicle function in services/director.py#189tanishqjasoria wants to merge 5 commits intouptane:developfrom
tanishqjasoria wants to merge 5 commits intouptane:developfrom
Conversation
|
@tanishqjasoria Can you add some test cases for this? |
While adding a vehicle the current working directory is changed.
Author
|
@mnm678 I have added a test for remove_director function! |
Author
|
While registering a vehicle with the director using the add_new_vehicle method, while creating the repository for the vehicle, the current working directory(which is the uptane working directory) is changed to the director repos directory (as the repository Tool expects to use the current directory) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR:
To resolve #59: Add method to remove vehicles from Director repo
Summary of Changes:
added a method deregister_vehicle
added method remove_vehicle
added method remove_director_repo_for_vehicle