Bugfixes for undeclared variables so it can be used on observable#11
Open
john-guerra wants to merge 1 commit into
Open
Bugfixes for undeclared variables so it can be used on observable#11john-guerra wants to merge 1 commit into
john-guerra wants to merge 1 commit into
Conversation
Owner
|
@john-guerra Thank you, I will take a look but can you exclude the re-formatting please? |
Author
|
Do you have a eslint configuration file that I could use? I was able to
find the bugs with the help of eslint and prettier
John Alexis Guerra Gómez
On my phone, brevity and all
…On Wed, Mar 22, 2023, 4:42 PM Corneliu Sugar ***@***.***> wrote:
@john-guerra <https://github.com/john-guerra> Thank you, I will take a
look but can you exclude the re-formatting please?
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJJCS4CTSVMZY4CXJF4IALW5OE5FANCNFSM6AAAAAAWDDST7Y>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a bunch of bugfixes to make it work on Observable. It would be nice to have this working as an npm module