Skip to content

VEL-7227 Add feedback message for OSS::Country selector#634

Merged
JulienVannier66 merged 1 commit intofeature/payment-requests-onboarding-reworkfrom
jv/vel-7083/country-selector-feedback-message
Feb 5, 2026
Merged

VEL-7227 Add feedback message for OSS::Country selector#634
JulienVannier66 merged 1 commit intofeature/payment-requests-onboarding-reworkfrom
jv/vel-7083/country-selector-feedback-message

Conversation

@JulienVannier66
Copy link
Contributor

What does this PR do?

This PR adds feedback message for OSS::CountrySelector component, allowing display of error, warning, or success messages below the input with corresponding border styling.

Component Updates:

  • Added @feedbackMessage argument accepting a FeedbackMessage type with type and value properties
  • Implemented computedClasses getter to dynamically apply styling based on feedback message type
  • Added feedback message display in template with color-coded text

Styling:

  • Added .country-selector-container--error, --warning, and --success modifiers
  • Each modifier applies corresponding input border styles

Testing:

  • Added comprehensive test coverage for all feedback message scenarios
  • Tests validate message display, border styling, and reactive updates
  • Coverage includes all allowed types (error, warning, success) and edge cases (null, undefined)

Documentation:

  • Added Storybook story demonstrating error feedback message usage
  • Updated demo template with examples of feedback message integration

What are the observable changes?

Screencast.from.2026-02-03.18-03-05.webm

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

@JulienVannier66 JulienVannier66 self-assigned this Feb 3, 2026
@linear
Copy link

linear bot commented Feb 3, 2026

@JulienVannier66 JulienVannier66 changed the title Add feedback message for OSS::Country selector Add feedback message for OSS::Country selector & VEL-7227 Feb 3, 2026
@JulienVannier66 JulienVannier66 changed the title Add feedback message for OSS::Country selector & VEL-7227 VEL-7227 Add feedback message for OSS::Country selector Feb 3, 2026
Copy link
Contributor

@aprentout aprentout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@JulienVannier66 JulienVannier66 merged commit 99f0b1f into feature/payment-requests-onboarding-rework Feb 5, 2026
3 checks passed
@JulienVannier66 JulienVannier66 deleted the jv/vel-7083/country-selector-feedback-message branch February 5, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants