Skip to content

Ensure mobile responsiveness on unified pages#278

Merged
pranavrao145 merged 9 commits intomainfrom
pranav/ensure-mobile-responsiveness
Mar 31, 2026
Merged

Ensure mobile responsiveness on unified pages#278
pranavrao145 merged 9 commits intomainfrom
pranav/ensure-mobile-responsiveness

Conversation

@pranavrao145
Copy link
Copy Markdown
Contributor

@pranavrao145 pranavrao145 commented Mar 29, 2026

TL;DR

Optimize unified pages for mobile. Other minor UI changes and code cleanup.

image image

Checklist

  • Changes have been top-hatted locally
  • Tests have been added or updated
  • Documentation has been updated (if applicable)
  • Linked related issues

@pranavrao145 pranavrao145 force-pushed the pranav/ensure-mobile-responsiveness branch from 03e816e to bc9f9b2 Compare March 29, 2026 20:01
@pranavrao145 pranavrao145 force-pushed the pranav/ensure-mobile-responsiveness branch from bc9f9b2 to 741766e Compare March 29, 2026 20:04
@pranavrao145 pranavrao145 marked this pull request as ready for review March 29, 2026 20:05
Copilot AI review requested due to automatic review settings March 29, 2026 20:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR focuses on improving mobile responsiveness and UX for the “unified” project/subproject selection flows (journals and log entries), including layout spacing, progressive form reveal, and updated i18n strings.

Changes:

  • Refactors the unified selection UI into a 2-step layout with Turbo Frame replacement + scroll reveal behavior.
  • Updates layout/flash positioning and component spacing for better mobile rendering.
  • Cleans up/renames translations and removes “empty form” placeholder components.

Reviewed changes

Copilot reviewed 28 out of 30 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
test/controllers/projects_controller_test.rb Adjusts controller success-route coverage (now omits new/edit).
config/locales/es/projects/subprojects/journals.es.yml Adds Spanish i18n for subproject journals CRUD + AR attributes.
config/locales/es/log_entries.es.yml Updates Spanish copy for log entry “new” title/subtitle.
config/locales/es/journals.es.yml Adds Spanish i18n for journals “new” title/subtitle.
config/locales/es/journal.es.yml Removes old Spanish journal i18n file.
config/locales/es/components.es.yml Updates component i18n (removes journal empty-form strings; adds unified-form step labels).
config/locales/en/projects/subprojects/journals.en.yml Adds English i18n for subproject journals CRUD + AR attributes.
config/locales/en/log_entries.en.yml Updates English copy for log entry “new” title/subtitle.
config/locales/en/journals.en.yml Adds English i18n for journals “new” title/subtitle.
config/locales/en/journal.en.yml Removes old English journal i18n file.
config/locales/en/components.en.yml Updates component i18n (removes journal empty-form strings; adds unified-form step labels).
app/views/shared/_flash.html.erb Makes flash container responsive on mobile (full-width bottom positioning).
app/views/projects/subprojects/log_entries/show.turbo_stream.erb Tweaks modal content spacing for log entry show.
app/views/log_entries/new.html.erb Wraps unified selection flow in a Turbo Frame and updates header styling.
app/views/layouts/application.html.erb Adds bottom padding to avoid overlap with fixed flash on mobile.
app/views/journals/new.html.erb Wraps unified selection flow in a Turbo Frame and updates header styling.
app/javascript/controllers/form_reveal_scroll_controller.js Adds Stimulus controller to scroll step 2 into view when it appears.
app/controllers/projects_controller.rb Changes new/edit to Turbo Stream–only responses.
app/controllers/projects/subprojects/log_entries_controller.rb Simplifies successful create response to a plain redirect.
app/components/sidebar_component.rb Adjusts admin nav items (removes “New Report” shortcut, reorders items).
app/components/projects/subprojects/unified_form_component.rb Adds selection helper methods and Turbo-Frame request detection for animations.
app/components/projects/subprojects/unified_form_component.html.erb Converts unified selector into a 2-step layout with Turbo Frame replacement.
app/components/project_attributes/form_component.html.erb Adjusts padding/spacing to improve responsiveness.
app/components/log_entries/form_component.html.erb Forces form submission to _top (better behavior when rendered in frames/modals).
app/components/log_entries/empty_form_component.rb Removes log entry empty placeholder component.
app/components/log_entries/empty_form_component.html.erb Removes log entry empty placeholder markup.
app/components/journals/form_component.html.erb Updates submit button styling for primary CTA appearance.
app/components/journals/empty_form_component.rb Removes journal empty placeholder component.
app/components/journals/empty_form_component.html.erb Removes journal empty placeholder markup.
app/builders/default_form_builder.rb Updates submit button default classes to include border styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/controllers/projects_controller_test.rb
Comment thread app/controllers/projects_controller.rb
Comment thread app/components/projects/subprojects/unified_form_component.rb Outdated
Comment thread app/views/log_entries/new.html.erb Outdated
Comment thread app/views/journals/new.html.erb Outdated
Comment thread app/components/sidebar_component.rb
Comment thread app/controllers/projects_controller.rb
Comment thread app/components/journals/form_component.html.erb
Comment thread app/components/sidebar_component.rb
Copilot AI review requested due to automatic review settings March 29, 2026 20:53
@pranavrao145 pranavrao145 force-pushed the pranav/ensure-mobile-responsiveness branch from 844c7bb to 3dca25e Compare March 29, 2026 20:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 32 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/controllers/projects_controller.rb
Comment thread test/controllers/projects_controller_test.rb
Comment thread test/controllers/projects_controller_test.rb
@pranavrao145 pranavrao145 force-pushed the pranav/ensure-mobile-responsiveness branch from 3dca25e to 86a8bd5 Compare March 30, 2026 01:49
Copilot AI review requested due to automatic review settings March 30, 2026 01:55
@pranavrao145 pranavrao145 force-pushed the pranav/ensure-mobile-responsiveness branch from 86a8bd5 to e0d492c Compare March 30, 2026 01:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 32 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/components/projects/subprojects/unified_form_component.rb
Comment thread app/controllers/projects_controller.rb
Comment thread app/controllers/projects_controller.rb
Comment thread app/controllers/projects_controller.rb
@pranavrao145 pranavrao145 force-pushed the pranav/ensure-mobile-responsiveness branch from 8a3830e to 987a512 Compare March 30, 2026 02:22
Copilot AI review requested due to automatic review settings March 30, 2026 02:23
@pranavrao145 pranavrao145 force-pushed the pranav/ensure-mobile-responsiveness branch from 987a512 to 0b499b9 Compare March 30, 2026 02:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 44 out of 46 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/controllers/projects/subprojects/log_entries_controller.rb Outdated
Copilot AI review requested due to automatic review settings March 30, 2026 02:45
@pranavrao145 pranavrao145 force-pushed the pranav/ensure-mobile-responsiveness branch from a28a4d0 to 744e701 Compare March 30, 2026 02:45
@pranavrao145 pranavrao145 force-pushed the pranav/ensure-mobile-responsiveness branch from 744e701 to c48e41e Compare March 30, 2026 02:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 56 out of 58 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/components/projects/subprojects/unified_form_component.rb
Comment thread app/controllers/projects/subprojects/log_entries_controller.rb
Comment thread app/controllers/projects/subprojects/log_entries_controller.rb Outdated
Comment thread app/javascript/controllers/form_reveal_scroll_controller.js
Copilot AI review requested due to automatic review settings March 30, 2026 02:56
@pranavrao145 pranavrao145 force-pushed the pranav/ensure-mobile-responsiveness branch from 673e679 to 3945040 Compare March 30, 2026 02:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 56 out of 58 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/controllers/users_controller_test.rb
Comment thread app/controllers/projects/subprojects/log_entries_controller.rb
@pranavrao145 pranavrao145 force-pushed the pranav/ensure-mobile-responsiveness branch from 3945040 to 95a31b2 Compare March 30, 2026 03:07
Copy link
Copy Markdown
Contributor

@CulmoneY CulmoneY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you tophatted this locally.

Copilot AI review requested due to automatic review settings March 31, 2026 00:22
@pranavrao145 pranavrao145 mentioned this pull request Mar 31, 2026
4 tasks
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 56 out of 58 changed files in this pull request and generated 10 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/controllers/users_controller.rb
Comment thread app/controllers/users_controller.rb
Comment thread app/controllers/projects_controller.rb
Comment thread app/controllers/projects_controller.rb
Comment thread app/controllers/regions_controller.rb
Comment thread app/controllers/regions_controller.rb
Comment thread app/controllers/subprojects_controller.rb
Comment thread app/controllers/subprojects_controller.rb
Comment thread app/controllers/projects/subprojects/log_entries_controller.rb
Comment thread app/controllers/projects/subprojects/log_entries_controller.rb
@pranavrao145 pranavrao145 merged commit c080f5b into main Mar 31, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants