Ensure mobile responsiveness on unified pages#278
Conversation
03e816e to
bc9f9b2
Compare
bc9f9b2 to
741766e
Compare
There was a problem hiding this comment.
Pull request overview
This PR focuses on improving mobile responsiveness and UX for the “unified” project/subproject selection flows (journals and log entries), including layout spacing, progressive form reveal, and updated i18n strings.
Changes:
- Refactors the unified selection UI into a 2-step layout with Turbo Frame replacement + scroll reveal behavior.
- Updates layout/flash positioning and component spacing for better mobile rendering.
- Cleans up/renames translations and removes “empty form” placeholder components.
Reviewed changes
Copilot reviewed 28 out of 30 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| test/controllers/projects_controller_test.rb | Adjusts controller success-route coverage (now omits new/edit). |
| config/locales/es/projects/subprojects/journals.es.yml | Adds Spanish i18n for subproject journals CRUD + AR attributes. |
| config/locales/es/log_entries.es.yml | Updates Spanish copy for log entry “new” title/subtitle. |
| config/locales/es/journals.es.yml | Adds Spanish i18n for journals “new” title/subtitle. |
| config/locales/es/journal.es.yml | Removes old Spanish journal i18n file. |
| config/locales/es/components.es.yml | Updates component i18n (removes journal empty-form strings; adds unified-form step labels). |
| config/locales/en/projects/subprojects/journals.en.yml | Adds English i18n for subproject journals CRUD + AR attributes. |
| config/locales/en/log_entries.en.yml | Updates English copy for log entry “new” title/subtitle. |
| config/locales/en/journals.en.yml | Adds English i18n for journals “new” title/subtitle. |
| config/locales/en/journal.en.yml | Removes old English journal i18n file. |
| config/locales/en/components.en.yml | Updates component i18n (removes journal empty-form strings; adds unified-form step labels). |
| app/views/shared/_flash.html.erb | Makes flash container responsive on mobile (full-width bottom positioning). |
| app/views/projects/subprojects/log_entries/show.turbo_stream.erb | Tweaks modal content spacing for log entry show. |
| app/views/log_entries/new.html.erb | Wraps unified selection flow in a Turbo Frame and updates header styling. |
| app/views/layouts/application.html.erb | Adds bottom padding to avoid overlap with fixed flash on mobile. |
| app/views/journals/new.html.erb | Wraps unified selection flow in a Turbo Frame and updates header styling. |
| app/javascript/controllers/form_reveal_scroll_controller.js | Adds Stimulus controller to scroll step 2 into view when it appears. |
| app/controllers/projects_controller.rb | Changes new/edit to Turbo Stream–only responses. |
| app/controllers/projects/subprojects/log_entries_controller.rb | Simplifies successful create response to a plain redirect. |
| app/components/sidebar_component.rb | Adjusts admin nav items (removes “New Report” shortcut, reorders items). |
| app/components/projects/subprojects/unified_form_component.rb | Adds selection helper methods and Turbo-Frame request detection for animations. |
| app/components/projects/subprojects/unified_form_component.html.erb | Converts unified selector into a 2-step layout with Turbo Frame replacement. |
| app/components/project_attributes/form_component.html.erb | Adjusts padding/spacing to improve responsiveness. |
| app/components/log_entries/form_component.html.erb | Forces form submission to _top (better behavior when rendered in frames/modals). |
| app/components/log_entries/empty_form_component.rb | Removes log entry empty placeholder component. |
| app/components/log_entries/empty_form_component.html.erb | Removes log entry empty placeholder markup. |
| app/components/journals/form_component.html.erb | Updates submit button styling for primary CTA appearance. |
| app/components/journals/empty_form_component.rb | Removes journal empty placeholder component. |
| app/components/journals/empty_form_component.html.erb | Removes journal empty placeholder markup. |
| app/builders/default_form_builder.rb | Updates submit button default classes to include border styling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
844c7bb to
3dca25e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 32 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3dca25e to
86a8bd5
Compare
86a8bd5 to
e0d492c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 32 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8a3830e to
987a512
Compare
987a512 to
0b499b9
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 44 out of 46 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a28a4d0 to
744e701
Compare
744e701 to
c48e41e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 56 out of 58 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
673e679 to
3945040
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 56 out of 58 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3945040 to
95a31b2
Compare
CulmoneY
left a comment
There was a problem hiding this comment.
I trust you tophatted this locally.
…rror of journal editor not loading
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 56 out of 58 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TL;DR
Optimize unified pages for mobile. Other minor UI changes and code cleanup.
Checklist