fix: create boot logs directory before syslog writes#2655
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR adds directory creation checks in two shell scripts to ensure ChangesBoot logs directory initialization
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔧 PR Test Plugin AvailableA test plugin has been generated for this PR that includes the modified files. Version: 📥 Installation Instructions:Install via Unraid Web UI:
Alternative: Direct Download
|
|
Actionable comments posted: 0 |
Summary
Why
Shutdown could emit
cp: cannot create regular file '/boot/logs/syslog': No such file or directorywhen the boot logs directory did not already exist.Validation
bash -n etc/rc.d/rc.6bash -n emhttp/plugins/dynamix/scripts/rsyslog_configSummary by CodeRabbit
Bug Fixes