Skip to content

fix(test): mock httpx.request instead of requests.request in make_request tests #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unohee merged 1 commit into from
Jun 3, 2026
Merged

fix(test): mock httpx.request instead of requests.request in make_request tests #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/unit/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def test_check_and_refresh_token_invalid_format(self, mock_get_tr_env, mock_auth

@patch("kis_agent.core.client.auth")
@patch("kis_agent.core.client.getTREnv")
@patch("requests.request")
@patch("httpx.request")
def test_make_request_success(self, mock_request, mock_get_tr_env, mock_auth):
"""API 요청 성공"""
mock_auth.return_value = {
Expand Down Expand Up @@ -221,7 +221,7 @@ def test_make_request_success(self, mock_request, mock_get_tr_env, mock_auth):

@patch("kis_agent.core.client.auth")
@patch("kis_agent.core.client.getTREnv")
@patch("requests.request")
@patch("httpx.request")
def test_make_request_json_decode_error(
self, mock_request, mock_get_tr_env, mock_auth
):
Expand Down Expand Up @@ -259,7 +259,7 @@ def test_make_request_json_decode_error(

@patch("kis_agent.core.client.auth")
@patch("kis_agent.core.client.getTREnv")
@patch("requests.request")
@patch("httpx.request")
def test_make_request_no_rt_cd(self, mock_request, mock_get_tr_env, mock_auth):
"""rt_cd 없는 응답 처리"""
mock_auth.return_value = {
Expand Down Expand Up @@ -289,7 +289,7 @@ def test_make_request_no_rt_cd(self, mock_request, mock_get_tr_env, mock_auth):

@patch("kis_agent.core.client.auth")
@patch("kis_agent.core.client.getTREnv")
@patch("requests.request")
@patch("httpx.request")
def test_make_request_api_error(self, mock_request, mock_get_tr_env, mock_auth):
"""API 오류 응답 처리"""
mock_auth.return_value = {
Expand Down Expand Up @@ -323,7 +323,7 @@ def test_make_request_api_error(self, mock_request, mock_get_tr_env, mock_auth):

@patch("kis_agent.core.client.auth")
@patch("kis_agent.core.client.getTREnv")
@patch("requests.request")
@patch("httpx.request")
def test_make_request_http_error_with_retry(
self, mock_request, mock_get_tr_env, mock_auth
):
Expand Down Expand Up @@ -363,7 +363,7 @@ def test_make_request_http_error_with_retry(

@patch("kis_agent.core.client.auth")
@patch("kis_agent.core.client.getTREnv")
@patch("requests.request")
@patch("httpx.request")
def test_make_request_exception_handling(
self, mock_request, mock_get_tr_env, mock_auth
):
Expand Down
26 changes: 13 additions & 13 deletions tests/unit/test_client_comprehensive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ def test_make_request_success(self):
mock_tr_env.my_token = "Bearer token"
mock_get_tr_env.return_value = mock_tr_env

with patch("requests.request") as mock_request:
with patch("httpx.request") as mock_request:
mock_response = MagicMock()
mock_response.status_code = 200
mock_response.json.return_value = {
Expand Down Expand Up @@ -392,7 +392,7 @@ def test_make_request_json_decode_error(self):
mock_tr_env.my_token = "Bearer token"
mock_get_tr_env.return_value = mock_tr_env

with patch("requests.request") as mock_request:
with patch("httpx.request") as mock_request:
mock_response = MagicMock()
mock_response.status_code = 200
# json.JSONDecodeError를 발생시켜야 함
Expand Down Expand Up @@ -426,7 +426,7 @@ def test_make_request_no_rt_cd(self):
mock_tr_env.my_token = "Bearer token"
mock_get_tr_env.return_value = mock_tr_env

with patch("requests.request") as mock_request:
with patch("httpx.request") as mock_request:
mock_response = MagicMock()
mock_response.status_code = 200
mock_response.json.return_value = {"data": "no_rt_cd"}
Expand Down Expand Up @@ -456,7 +456,7 @@ def test_make_request_api_error(self):
mock_tr_env.my_token = "Bearer token"
mock_get_tr_env.return_value = mock_tr_env

with patch("requests.request") as mock_request:
with patch("httpx.request") as mock_request:
mock_response = MagicMock()
mock_response.status_code = 200
mock_response.json.return_value = {
Expand Down Expand Up @@ -508,7 +508,7 @@ def side_effect(*args, **kwargs):
}
return mock_response

with patch("requests.request", side_effect=side_effect):
with patch("httpx.request", side_effect=side_effect):
client = client_module.KISClient(
enable_rate_limiter=False, verbose=False
)
Expand Down Expand Up @@ -552,7 +552,7 @@ def side_effect(*args, **kwargs):
}
return mock_response

with patch("requests.request", side_effect=side_effect), patch(
with patch("httpx.request", side_effect=side_effect), patch(
"time.sleep"
): # 대기 시간 건너뛰기
client = client_module.KISClient(
Expand All @@ -578,7 +578,7 @@ def test_make_request_http_error(self):
mock_tr_env.my_token = "Bearer token"
mock_get_tr_env.return_value = mock_tr_env

with patch("requests.request") as mock_request:
with patch("httpx.request") as mock_request:
mock_response = MagicMock()
mock_response.status_code = 500
mock_response.json.return_value = {
Expand Down Expand Up @@ -612,7 +612,7 @@ def test_make_request_request_exception(self):
mock_tr_env.my_token = "Bearer token"
mock_get_tr_env.return_value = mock_tr_env

with patch("requests.request") as mock_request:
with patch("httpx.request") as mock_request:
mock_request.side_effect = requests.exceptions.ConnectionError(
"Connection failed"
)
Expand Down Expand Up @@ -640,7 +640,7 @@ def test_make_request_post_method(self):
mock_tr_env.my_token = "Bearer token"
mock_get_tr_env.return_value = mock_tr_env

with patch("requests.request") as mock_request:
with patch("httpx.request") as mock_request:
mock_response = MagicMock()
mock_response.status_code = 200
mock_response.json.return_value = {"rt_cd": "0"}
Expand Down Expand Up @@ -672,7 +672,7 @@ def test_make_request_verbose_logging(self):
mock_tr_env.my_token = "Bearer token"
mock_get_tr_env.return_value = mock_tr_env

with patch("requests.request") as mock_request:
with patch("httpx.request") as mock_request:
mock_response = MagicMock()
mock_response.status_code = 200
mock_response.json.return_value = {"rt_cd": "0", "output": {}}
Expand Down Expand Up @@ -809,7 +809,7 @@ def test_get_kospi200_index(self):
mock_tr_env.my_token = "Bearer token"
mock_get_tr_env.return_value = mock_tr_env

with patch("requests.request") as mock_request:
with patch("httpx.request") as mock_request:
mock_response = MagicMock()
mock_response.status_code = 200
mock_response.json.return_value = {
Expand Down Expand Up @@ -982,7 +982,7 @@ def test_rate_limiter_report_success(self):
mock_tr_env.my_token = "Bearer token"
mock_get_tr_env.return_value = mock_tr_env

with patch("requests.request") as mock_request:
with patch("httpx.request") as mock_request:
mock_response = MagicMock()
mock_response.status_code = 200
mock_response.json.return_value = {"rt_cd": "0"}
Expand Down Expand Up @@ -1016,7 +1016,7 @@ def test_rate_limiter_report_error(self):
mock_tr_env.my_token = "Bearer token"
mock_get_tr_env.return_value = mock_tr_env

with patch("requests.request") as mock_request:
with patch("httpx.request") as mock_request:
mock_response = MagicMock()
mock_response.status_code = 200
mock_response.json.return_value = {
Expand Down
Loading