current()#3
Open
mikedevelops wants to merge 12 commits into
Open
Conversation
- Most builtins here have integration tests to ensure basic functionality, but unit tests still need to be written for a large number. - Docblocks are missing from some functions - Any unsupported behaviour needs to throw a meaningful error message
Add docblock, warnings and unit tests for `array_values(...)`
Contributor
|
Thanks very much again @mikedevelops ! Yeah, I guess we should cover objects too - |
Contributor
|
Do you think it would be worth adding some integration test(s) too? Probably overkill to add one for each of these array iteration functions, but we could add one that uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added docblock, argument warnings and tests.
I noticed in the docs an object can also be passed into current, not sure if we want to cover this?