Devops: publish documentation using first-party actions#3107
Conversation
- Remove `s0/git-publish-subdir-action@v2.2.0` which is no longer actively maintained. - Use action instead of branch to publish doc. Co-authored-by: Zhihao Dai <zhihao.dai@eng.ox.ac.uk>
Co-authored-by: Zhihao Dai <zhihao.dai@eng.ox.ac.uk>
Co-authored-by: Zhihao Dai <zhihao.dai@eng.ox.ac.uk>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3107 +/- ##
==========================================
- Coverage 96.31% 96.24% -0.07%
==========================================
Files 161 161
Lines 17356 17356
==========================================
- Hits 16716 16705 -11
- Misses 640 651 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Zhihao Dai <zhihao.dai@eng.ox.ac.uk>
|
Hi @daidahao, thanks for the PR! |
|
Thank you for taking a close look at this and I am glad that you agree with the proposal. Regarding the Another outdated job I have looked at is |
dennisbader
left a comment
There was a problem hiding this comment.
Looks great, thanks a lot @daidahao 🚀
Will merge once all tests have passed
|
@daidahao, I also updated the GitHub Pages settings, so this one should be good to go 💯 |
Checklist before merging this PR:
Fixes #.
Summary
This PR proposes using GitHub Actions to publish the documentation to GitHub Pages, replacing the previous third-party branch-based deployment method.
I am a bit wary of using third-party action
s0/git-publish-subdir-action@v2.2.0for publishing the documentation. The action has not been updated in a long time (last release was 2022), is owned by an individual, and has access tosecrets.GITHUB_TOKENwhich could write to any branch.Meanwhile, the GitHub Pages documentation recommends using actions/upload-pages-artifact and actions/deploy-pages, both first-party actions, to publish the site. This PR adopts the flow for better security and long-term support.
As suggested in actions/deploy-pages, I've also:
deploy-docsintobuild-docsanddeploy-docsto prevent code executionGITHUB_TOKENpermissions fordeploy-docsjob to only those necessary.@dennisbader If you agree with this, you would need to change Pages settings for the next release to use "GitHub Actions" as source to replace "Deploy from a branch".
Other Information