Skip to content
This repository was archived by the owner on Apr 6, 2026. It is now read-only.

changing np.float to float#22

Open
ramav87 wants to merge 1 commit into
underchemist:masterfrom
ramav87:master
Open

changing np.float to float#22
ramav87 wants to merge 1 commit into
underchemist:masterfrom
ramav87:master

Conversation

@ramav87
Copy link
Copy Markdown

@ramav87 ramav87 commented Mar 27, 2023

np.float, np.int and np.complex are all deprecated in numpy 1.20. It is suggested to change these to float(), int() and complex() to avoid warnings during test (and potentially future errors). This update passes the tests without warnings (see below).

(base) D:\Github\nanonispy>pytest
================================================= test session starts =================================================
platform win32 -- Python 3.9.13, pytest-7.1.2, pluggy-1.0.0
rootdir: D:\Github\nanonispy
plugins: anyio-3.5.0
collected 26 items

tests\test_read.py ..........................                                                                    [100%]

================================================= 26 passed in 6.60s ==================================================

@ramav87
Copy link
Copy Markdown
Author

ramav87 commented May 11, 2023

Can you please accept the pull request and release a new version?

@RubelMozumder
Copy link
Copy Markdown

@underchemist, Would you please accept this pull request, and release a new version. We are getting errors while using this package as np.float is deprecated.

@ramav87
Copy link
Copy Markdown
Author

ramav87 commented Jul 21, 2023

Hi, can you please accept this PR??

@vanessa-king
Copy link
Copy Markdown

I also would like to see this change made. @underchemist please accept this PR.

@ceds92 ceds92 mentioned this pull request Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants