Simplify API, esp. generic and async types #12
Open
pursultani wants to merge 6 commits intomasterfrom
Open
Conversation
added 3 commits
July 14, 2018 20:07
Including the following: - Reduced or simplified generics - Add enterypoint for API - Reduced or simplified async types - Renamed interfaces - Unified generic names
Author
|
WIP At the moment SPI build fails. I haven't refactored/re-implemented corresponding SPI interfaces. |
added 3 commits
July 27, 2018 16:42
The old implementation of Lifecycle and Context classes are removed. They must be adapted later to the new changes in the API. Also, a workaround is added to run factory initialization at runtime. Includes minor changes to the API.
mmnaseri
reviewed
Aug 12, 2018
| * @param input | ||
| * @return | ||
| */ | ||
| Hit<M> test(I input); |
|
|
||
| } | ||
|
|
||
| interface Hit<M> { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Java language designers will rue the day they added generics ... when they see our API" 😄