Skip to content

Popover Container: Set a dynamic max-height for the popover.#1235

Draft
engijlr wants to merge 4 commits intov1/devfrom
v1/bugfix/show-scrollbar-for-popover-container
Draft

Popover Container: Set a dynamic max-height for the popover.#1235
engijlr wants to merge 4 commits intov1/devfrom
v1/bugfix/show-scrollbar-for-popover-container

Conversation

@engijlr
Copy link
Contributor

@engijlr engijlr commented Nov 26, 2025

Fixed: umbraco/Umbraco-CMS#19073

Problem:

Dropdown with many items had no scrollbar. Users could not see or click items that went beyond the screen.

Solution:

Changed CSS from overflow: visible to overflow: auto so scrollbars appear when needed.
Added dynamic max-height calculation:

  • Calculates available space above/below the trigger button.
  • Sets max-height to 90% of available space (leaving 10% padding).

Screenshots

Screenshot 2025-11-26 at 15 44 57 Screenshot 2025-11-26 at 13 53 17

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@nielslyngsoe
Copy link
Member

This is introducing a scrollbar for the popover, which previously was implemented by the content. See combo box as an example.
We need to figure out how such can play well together. Maybe we cannot provide a scrollbar, meaning this will only work if the content it self stay flexible. That would open up for other ways to handle small space.

Until that is resolved i will mark this as a draft.

@nielslyngsoe nielslyngsoe marked this pull request as draft January 28, 2026 09:42
@engijlr engijlr changed the base branch from main to v1/dev February 19, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

15.4.0-rc There is no scroll in dropdown while filtering user groups

2 participants