Popover Container: Set a dynamic max-height for the popover.#1235
Draft
Popover Container: Set a dynamic max-height for the popover.#1235
Conversation
|
|
Member
|
This is introducing a scrollbar for the popover, which previously was implemented by the content. See combo box as an example. Until that is resolved i will mark this as a draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixed: umbraco/Umbraco-CMS#19073
Problem:
Dropdown with many items had no scrollbar. Users could not see or click items that went beyond the screen.
Solution:
Changed CSS from
overflow: visibletooverflow: autoso scrollbars appear when needed.Added dynamic max-height calculation:
max-heightto 90% of available space (leaving 10% padding).Screenshots