Skip to content

Feature: uui-divider component#1115

Open
bjarnef wants to merge 3 commits intoumbraco:mainfrom
bjarnef:feature/uui-divider
Open

Feature: uui-divider component#1115
bjarnef wants to merge 3 commits intoumbraco:mainfrom
bjarnef:feature/uui-divider

Conversation

@bjarnef
Copy link
Copy Markdown
Contributor

@bjarnef bjarnef commented May 29, 2025

Description

Added a new uui-divider component similar to this: https://shoelace.style/components/divider/
I think it may to useful to separate content, menu items etc.

It can possible also replace divider here in CMS (unless we want a separate component for this or split panel like this: https://shoelace.style/components/split-panel/ )

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

image

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copilot AI review requested due to automatic review settings May 29, 2025 20:42
@github-actions
Copy link
Copy Markdown

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds a new uui-divider component to the project.

  • Introduces the divider component files (element, tests, stories, etc.).
  • Updates the main index exports and project configuration files to incorporate the new component.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/uui/lib/index.ts Added export for the uui-divider package
packages/uui-divider/tsconfig.json Created TS configuration for the divider component
packages/uui-divider/rollup.config.js Configured rollup for uui-divider package
packages/uui-divider/package.json Defined package details and dependencies
packages/uui-divider/lib/uui-divider.test.ts Added tests for the divider component
packages/uui-divider/lib/uui-divider.story.ts Added storybook stories for the divider component
packages/uui-divider/lib/uui-divider.element.ts Implemented the divider component with customizable props
packages/uui-divider/lib/index.ts Set up component export
packages/uui-divider/README.md Documented component installation and usage

Comment thread packages/uui-divider/lib/uui-divider.story.ts Outdated
@bjarnef bjarnef changed the title Add uui-divider component Feature: uui-divider component May 29, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

@nielslyngsoe
Copy link
Copy Markdown
Member

Hi @bjarnef a late follow up on this PR — as they say: better late than never.

For this to follow the concept of UI Library, it should be less customizable.
The UI Library is a set of components available for any UI to compose, and then by using them the design will adhere to Umbraco/Backoffice. For that to be true the amount of configuration options has to be the absolute minimum needed. Cause having customizations, means overwrites, overwrites meens diviate from the given — resulting in in consistency and eventually not following along.

So currently we would have our dividers of a certain color and width, but maybe in v.19 that would be adjusted, everyone using this component should then follow along, automatically, and that can only happen if they did not customize it. So if we can get rid of the customization options, then it should be good to get in :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants