Rework connection teardown logic#1713
Open
rblenkinsopp wants to merge 2 commits intodevelopfrom
Open
Conversation
8 tasks
4e2e6df to
daae785
Compare
This was referenced Apr 30, 2026
daae785 to
6b5151d
Compare
6b5151d to
884543e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a number oc changes to improve
Connectionteardown logic:Connectionthat exhausted the Unity process's OS handle limit after repeated play-mode start/stop cycles.Controllerwhere event subscriptions on the pooledConnectionwere not removed on disposal.Connectionshutdown which could lead to delays in applications exiting.