Add Phase 2 learned router training and evaluation#1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR delivers roadmap Part 2 by turning
LearnedRouterinto a real trainable router and adding the end-to-end pieces needed to use it in practice.It adds:
What Changed
LearnedRouterto learn metric weights from labeled relevance data instead of training toward uniform weights.fit_from_relevance(...)to derive routing targets from per-metric retrieval quality.evaluate_from_relevance(...)andLearnedRouterEvaluationfor measuring learned routing quality.refract.search(...).save()/load()support for trained routers.examples/train_learned_router.pyexamples/evaluate_learned_router.pytests/unit/test_learned_router.py.learnedextra, since the new implementation uses existing sklearn-based dependencies.Notes
Validation
Ran locally:
ruff check src testsruff format --check src testspytest tests/ -x -q --tb=shortpytest tests/python examples/train_learned_router.pypython examples/evaluate_learned_router.pyruff check src tests examples/train_learned_router.py examples/evaluate_learned_router.pyruff format --check src tests examples/train_learned_router.py examples/evaluate_learned_router.pyReviewer Focus
LearnedRouter