fix editRestaurant by adding session add/commit lines#79
Open
sattamjh wants to merge 1 commit intoudacity:masterfrom
Open
fix editRestaurant by adding session add/commit lines#79sattamjh wants to merge 1 commit intoudacity:masterfrom
sattamjh wants to merge 1 commit intoudacity:masterfrom
Conversation
|
I second this fix! Just finished up this part of the course and checked the Udacity solutions compared to mine. Wouldn't this be a big issue if it were on a live system? While the user see's a temporary edit, once the webserver reads from the database, it would reload the old name since it never got added and committed. 😖 |
ghost
approved these changes
Aug 8, 2017
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Looks good to me. Can't get to the Database without it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the missing two lines of session add and commit to save the data in the database.