-
Notifications
You must be signed in to change notification settings - Fork 34
Add IC3/PDR engine for unbounded safety verification #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lsk567
wants to merge
10
commits into
master
Choose a base branch
from
ic3/pdr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6a7d28c
Add IC3/PDR engine for unbounded safety property verification
lsk567 b1d7b57
Update macOS CI runner from macos-13 to macos-14
lsk567 57c3130
Fix macOS CI: replace deprecated setup-scala with proper JDK/SBT setup
lsk567 a09a1ce
Fix macOS CI: use setup-java@v4 with Zulu for ARM64 compatibility
lsk567 0716ebc
Add IC3 tests to CI regression suite
lsk567 20c3cd5
Clean up IC3/PDR PR review items
lsk567 f45b5db
Print inductive invariant when IC3 proves a property safe
lsk567 d8cf08e
Fix IC3 soundness bug: handle bitvector values in Z3 model evaluation
lsk567 e3b4ff2
Add bitvector overflow test to IC3 CI regression suite
lsk567 830c748
Address round-2 review: handle all datatypes, fix non-termination
lsk567 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,16 @@ libraryDependencies += "org.scalatest" %% "scalatest" % "3.2.2" % "test" | |
| libraryDependencies += "com.github.scopt" %% "scopt" % "3.7.1" | ||
| libraryDependencies += "org.json4s" %% "json4s-jackson" % "4.0.3" | ||
|
|
||
| // Fork the JVM for run/test so that javaOptions take effect. The java.library.path | ||
| // setting is needed for Z3 JNI native library loading (libz3java). While the setup | ||
| // scripts (setup-z3-linux.sh, etc.) set LD_LIBRARY_PATH for shell use, java.library.path | ||
| // must be set at JVM startup to locate native libraries when running via sbt. | ||
| fork in run := true | ||
| javaOptions in run += s"-Djava.library.path=${baseDirectory.value}/z3/bin" | ||
|
|
||
| fork in Test := true | ||
| javaOptions in Test += s"-Djava.library.path=${baseDirectory.value}/z3/bin" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why do we need this now? |
||
|
|
||
| // do not require tests before building a fat JAR | ||
| test in assembly := {} | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this now?