This repository was archived by the owner on Jun 6, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
LIBTREATDB-131 pull modals out from views #624
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janell-Huyck
commented
May 7, 2025
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public/.well-known/appspecific/com.chrome.devtools.json is simply an empty file to quiet an error being generated by the web browser.
Identify and click the Rails UJS delete link via its and attributes instead of an outdated ID. Wrap the click in with retries, and assert that the repair text is removed from the page.
Extract the record ID from instead of using a static factory ID when constructing the delete-link . This ensures the test targets the actual URL rendered in the browser and avoids mismatches between factory IDs and UI-created records.
Contributor
Author
|
When run locally with the updated package.json for Babel version 7.27, the new extracted modals open, save, and auto-close appropriately and the database is updated correctly. Updating to Babel 7.27 is beyond the scope of this PR, but this PR needs to be merged before the Babel PR can be. |
Contributor
Author
|
PR relocated to git.uc.edu |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue: LIBTREATDB-131
What’s changed
Why
Test refactor
All existing behaviors are preserved; this simply reorganizes the view code and tightens up our test coverage for both the index and show pages.