TES tests: improve Nextflow log parsing#561
Merged
Merged
Conversation
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Integration Tests on KindTest summary after running integration tests
Test summary after rerunning failed integration tests
|
paulineribeyre
changed the title
Integration Tests on Kind
|
nss10
previously approved these changes
Jun 2, 2026
Contributor
nss10
left a comment
nss10
left a comment
There was a problem hiding this comment.
Function looks good, left a comment about variable names. They seem slightly confusing.
| if task["process_name"] not in res: | ||
| res[task["process_name"]] = task | ||
| continue | ||
| prev_timestamp = parser.parse(task["timestamp"]) |
Contributor
There was a problem hiding this comment.
Wait, does prev_timestamp mean previous timestamp? It seems like we are storing the current/new timestamp in here and storing the timestamp of an already processed line in the new_timestamp.
Can we rename prev_timestamp --> current_timestamp and new_timestamp --> stored_timestamp
Contributor
Author
There was a problem hiding this comment.
yes i just noticed this! pushing a fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes