minimal changes (6): deprecated part ; missing check at layout opensuse ; keep history-last-run ; active compiz was not detected ; check Layout saved ; check exists before remove#112
Open
2387skju wants to merge 6 commits into
Conversation
5bb8b2d to
423963e
Compare
3c86076 to
b374279
Compare
b374279 to
e45059d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6 (mostly) unimportant changes:
1.) Deprecated gtk parameter updated:
Update to GTK Parameters, to remove these deprecated warnings:
2.) For layout
Opensuseismate-menurequired:It has
MateMenuAppletFactory::MateMenuApplet(see in layout-file Opensuse).Problem results in: I don't see there any Menu at Debian, without installing that package.
Suggest: Distributions should add
mate-menuas suggested package (for mate-tweak).This is an re-opened of an already closed pull Request (i realized afterwards):
"add mate_menu dependency on opensuse layout": #72
But, I thinks this was wrongly closed.
3.) Keep history-last-run:
This keeps the current run program history of the user, while changing the Panel.
4.) Active
compizwas not detectedActive Windowmanager compiz was not correct detected, after opening Mate-Tweak once again: The Buttons for Reset and CCSM was missing and red text ".. unknown and unsupported windowmanager. ...".
Problem is: variable current_wm='compiz', but is checked for 'Compiz' (initial letter different).
I changed the code, to be not case-sensitive anymore.
5.) Check Layout saved / deleted
If layout was not saved or deleted, stop continue.
Use-Case: That could happened, if pkexec failed: The distribution opensuse does not include the policy-file, therefore it will ask for password. The User could cancel (or fail) that password request.
6.) check exist before remove a system-wide autostart
Check if the autostart file exists, before remove them ( = calling
pkexec mate_tweak_helper autostop ...).This will result in less actions with Root-Right.
Use-Case: The distribution opensuse does not ship the policy-file (= So, every root-request a needs password ).