Feature/dotnet host functions#2
Draft
ubiquitous-dev wants to merge 25 commits into
Draft
Conversation
the call to extism_plugin_new wasn't properly handling the exception case where a -1 pointer was returned to indicate an issue creating the plugin
Changed plugin reference to be a 32-bit signed integer, since it is the index of the plugin in an array of plugins within that context, not a pointer.
Determine if task had an exception, and if so, rethrow it, instead of always throwing TaskCanceledException
…iquitous-dev/extism into feature/dotnet-host-functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.