Fix hashCode/equals contract violation in XType.hash()#275
Merged
Conversation
The `else` branch of `hash()` was using identity-based `hashCode()`, while `isEquivalent()` (used by `equals()`) performed value-based comparison via `typeName`. This caused equivalent XType instances — particularly those originating from mixed Java and Kotlin sources in KSP — to produce different hash codes, breaking HashMap deduplication in the scope graph. Replace the identity `hashCode()` with `typeName.removeWildcardTypeIfContains().toString().hashCode()` to match the equivalence logic, and remove the now-redundant `hasCollectionType` branch which did the same thing.
|
|
ryanulep
approved these changes
Jun 15, 2026
jbarr21
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix hashCode/equals contract violation in XType.hash() that caused duplicate type entries in the scope graph when mixing Java and Kotlin sources after migrating to KSP2. In KSP2, equivalent parameterized types from Java and Kotlin sources produce distinct XType instances (KSP1 cached/shared them), exposing a latent bug: the else branch used identity-based hashCode() while equals() delegates to value-based isEquivalent(). Replace with typeName.removeWildcardTypeIfContains().toString().hashCode() to match the equivalence logic, and remove the now-redundant hasCollectionType branch.
Testing:
Add unit test that reproduces the bug using mixed Java+Kotlin sources returning the same parameterized type (Wrapper)