Model cadence's Future.Get as an error-return non-nil-arg hook#427
Merged
Conversation
Add error-return hook modeling for cadence's `Future.Get(ctx, &v)`: when the returned error is checked to be nil, the value pointed to by `&v` is treated as non-nil, mirroring the existing json/xml `Unmarshal` modeling. Includes minimal cadence stubs (internal + workflow alias) and inference-enabled test cases. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
=======================================
Coverage 87.26% 87.26%
=======================================
Files 74 74
Lines 8444 8444
=======================================
Hits 7369 7369
Misses 876 876
Partials 199 199 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sonalmahajan15
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add error-return hook modeling for cadence's
Future.Get(ctx, &v): when the returned error is checked to be nil, the value pointed to by&vis treated as non-nil, mirroring the existing json/xmlUnmarshalmodeling. Includes minimal cadence stubs (internal + workflow alias) and inference-enabled test cases.