Model implicit pointer-to-array dereferences as nil consumers#423
Open
TvdW wants to merge 1 commit into
Open
Conversation
Slicing, indexing, and 2-variable ranging over a *[N]T implicitly dereference the pointer (e.g. p[low:high] is shorthand for (*p)[low:high]), so they panic on a nil pointer. Notably this holds even for slice forms like p[:0] and p[:] that are safe on a nil slice. len/cap and range loops with at most one (possibly blank) iteration variable never read the elements and stay nil-safe. Add PtrLoad consumers for these cases in consumeIndexExpr, the SliceExpr case of AddComputation (bypassing the slice-only safe-slicing carve-out), and case 2 of backpropAcrossRange.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
==========================================
+ Coverage 87.26% 87.29% +0.02%
==========================================
Files 74 74
Lines 8444 8463 +19
==========================================
+ Hits 7369 7388 +19
Misses 876 876
Partials 199 199 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slicing, indexing, and 2-variable ranging over a *[N]T implicitly dereference the pointer (e.g. p[low:high] is shorthand for (*p)[low:high]), so they panic on a nil pointer. Notably this holds even for slice forms like p[:0] and p[:] that are safe on a nil slice. len/cap and range loops with at most one (possibly blank) iteration variable never read the elements and stay nil-safe.
Add PtrLoad consumers for these cases in consumeIndexExpr, the SliceExpr case of AddComputation (bypassing the slice-only safe-slicing carve-out), and case 2 of backpropAcrossRange.
Claude-assisted, human-reviewed.