Generate data files with frozen_string_literal: true#20
Open
casperisfine wants to merge 1 commit intotzinfo:masterfrom
Open
Generate data files with frozen_string_literal: true#20casperisfine wants to merge 1 commit intotzinfo:masterfrom
casperisfine wants to merge 1 commit intotzinfo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not a lot, but some of the strings in these generated files are duplicated and a bit of memory could be saved by enabling
frozen_string_literal.There's another source of duplication that could be removed, but not sure if you'd be open to the fix.
For instance:
Here
"Cuba"exist twice, one is the backing string for:Cubasymbol, because they are automatically casted asUS-ASCIIwhen applicable:So a trick to reduce the memory further could be to set
# encoding: US-ASCII.