Skip to content

add thinky typings #806

Open
claytonsilva wants to merge 2 commits into
typings:masterfrom
xdevelsistemas:master
Open

add thinky typings #806
claytonsilva wants to merge 2 commits into
typings:masterfrom
xdevelsistemas:master

Conversation

@claytonsilva
Copy link
Copy Markdown

@claytonsilva claytonsilva commented Oct 2, 2016

Typings URL: https://github.com/xdevelsistemas/typings-thinky

Questions (for new typings):

  • Does the README explain the purpose of the typings and have a link to the JavaScript project?
  • Do the typings follow the source structure (e.g. index.js <-> index.d.ts)?
  • Are they external or global modules according the source (e.g. see README sources)?

Change Summary (for existing typings):

Typings for thinky orm https://thinky.io/

@blakeembrey
Copy link
Copy Markdown
Member

Projects under npm/ need to be written in external module format (not global). The main change required is that you don't wrap the project in declare module "thinky".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants