Skip to content

adding chai-xml#313

Closed
rhysawilliams2010 wants to merge 6 commits into
typings:masterfrom
rhysawilliams2010:master
Closed

adding chai-xml#313
rhysawilliams2010 wants to merge 6 commits into
typings:masterfrom
rhysawilliams2010:master

Conversation

@rhysawilliams2010
Copy link
Copy Markdown
Contributor

@blakeembrey
Copy link
Copy Markdown
Member

@rhysawilliams2010 I can't merge this because of the augmentation of the namespace hack instead of the real name. Unfortunately, I know that's currently the only way to make it work. It's been discussed in #270 (comment) and the fix is currently blocked by a compiler issue in TypeScript. I'll let you know when it's fixed and we can merge.

Rhys Williams added 4 commits April 21, 2016 13:35
@rhysawilliams2010
Copy link
Copy Markdown
Contributor Author

I have changed the branch on my fork for this PR. There is a new PR here which i have already closed: #344 . I can reopen later when I can make it less hacky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants