fix(types): align curation rule tags with server semantics#338
Merged
tharropoulos merged 2 commits intotypesense:masterfrom Mar 26, 2026
Merged
fix(types): align curation rule tags with server semantics#338tharropoulos merged 2 commits intotypesense:masterfrom
tharropoulos merged 2 commits intotypesense:masterfrom
Conversation
- allow curation rule tags to be combined with query and filter rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
The type definition for curation rule creation was too restrictive, allowing only parts of
query,filterandtagsto be combined when defining a curation rule, when the actual Typesense server semantics allowed a mix of all three. Allow any combination of the types to be valid, but still enforce existence ofmatchwhenqueryis defined, and vice versa.PR Checklist