Skip to content

Fix/curation set types #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zaffron wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix/curation set types #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad1d582
fix(collections): add curation_sets to CollectionUpdateSchema
zaffron Mar 12, 2026
aa1bf50
fix(curation): use dedicated upsert schema for CurationSetItem
zaffron Mar 12, 2026
12e408f
fix(collections): remove redundant properties from CollectionUpdateSc…
zaffron Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Typesense/Collection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ export interface CollectionDropFieldSchema {
export interface CollectionUpdateSchema
extends Partial<Omit<CollectionCreateSchema, "name" | "fields">> {
fields?: (CollectionFieldSchema | CollectionDropFieldSchema)[];
synonym_sets?: string[];
}

export interface CollectionDeleteOptions {
Expand Down
6 changes: 5 additions & 1 deletion src/Typesense/CurationSetItem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import ApiCall from "./ApiCall";
import CurationSets from "./CurationSets";
import type { CurationObjectSchema } from "./CurationSets";

export type CurationItemUpsertSchema = Omit<CurationObjectSchema, "id">;

export interface CurationItemDeleteResponseSchema {
id: string;
}
Expand All @@ -17,7 +19,9 @@ export default class CurationSetItem {
return this.apiCall.get<CurationObjectSchema>(this.endpointPath());
}

async upsert(params: CurationObjectSchema): Promise<CurationObjectSchema> {
async upsert(
params: CurationItemUpsertSchema,
): Promise<CurationObjectSchema> {
return this.apiCall.put<CurationObjectSchema>(this.endpointPath(), params);
}

Expand Down