feat(tii): resolve custom-type params instead of throwing#33
Merged
Conversation
ParamType.fromJsonSchema threw on object schemas and unknown $refs, so any transaction with a record/variant param broke when building the param map. Map inline objects, `oneOf`, and `#/components/schemas` refs to ParamType.custom (resolving the ref against components when present), and match builtin refs by trailing name so both the `tii#/$defs/<Name>` and legacy `core#<Name>` forms resolve. Thread components through paramsFromSchema. Also regenerate the codegen template to declare named types from components.schemas. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stop throwing on custom-type params, and declare named types in generated
clients.
Why
ParamType.fromJsonSchemathrewunsupported type: object/unknown $ref,so any transaction with a record or variant param broke when building the
param map — custom types were effectively unusable end-to-end.
Changes
objectschemas,oneOf(variants), and#/components/schemas/...refs toParamType.custom(schema)(resolving theref against
componentswhen provided).…/tii#/$defs/<Name>formthe emitter produces and the legacy
…/core#<Name>form resolve.componentsthroughparamsFromSchema.components.schemas.8 new
paramTypetests; full unit suite (128) green.Pairs with
tx3-lang/tx3(emitter + codegen).🤖 Generated with Claude Code