Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR separates the Docker build into multiple specialized services, splitting the monolithic "final" target into separate containers for different components.
- Added individual Docker build targets for each service (prover, egressa, scheduler, aggregator, solana-scheduler, twine-node)
- Updated CI workflow to build all new Docker targets instead of the single "final" target
- Removed empty line and restructured Dockerfile to support multi-stage builds for better service isolation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| Dockerfile | Added 6 new Docker build stages for individual services, each with their own base image and dependencies |
| .github/workflows/main.yml | Updated docker_targets to build all new service-specific containers instead of the monolithic final target |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| PATH="/root/.cargo/bin:${PATH}" | ||
|
|
||
| RUN apt update && \ | ||
| apt update && \ |
There was a problem hiding this comment.
Duplicate 'apt update' command. Remove the redundant second occurrence.
| apt update && \ |
| PATH="/root/.cargo/bin:${PATH}" | ||
|
|
||
| RUN apt update && \ | ||
| apt update && \ |
There was a problem hiding this comment.
Duplicate 'apt update' command. Remove the redundant second occurrence.
| apt update && \ |
| PATH="/root/.cargo/bin:${PATH}" | ||
|
|
||
| RUN apt update && \ | ||
| apt update && \ |
There was a problem hiding this comment.
Duplicate 'apt update' command. Remove the redundant second occurrence.
| apt update && \ |
| RUN apt update && \ | ||
| apt update && \ |
There was a problem hiding this comment.
Duplicate 'apt update' command. Remove the redundant second occurrence.
| PATH="/root/.cargo/bin:${PATH}" | ||
|
|
||
| RUN apt update && \ | ||
| apt update && \ |
There was a problem hiding this comment.
Duplicate 'apt update' command. Remove the redundant second occurrence.
| apt update && \ |
| docker_targets: '["prover", "egressa", "scheduler", "twine-node", "aggregator", "solana-scheduler | ||
| "]' |
There was a problem hiding this comment.
The JSON array is split across lines incorrectly. The closing quote and bracket should be on the same line as the opening elements.
| docker_targets: '["prover", "egressa", "scheduler", "twine-node", "aggregator", "solana-scheduler | |
| "]' | |
| docker_targets: '["prover", "egressa", "scheduler", "twine-node", "aggregator", "solana-scheduler"]' |
Comment out various build and installation steps in the Dockerfile, including Rust installation and multiple COPY commands.
No description provided.