feat: embed debug symbols for cross platform#340
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates C# project build settings to embed debug symbols in assemblies (improving cross-platform debugging ergonomics) and adjusts analyzer configuration for the Extensions projects/tests.
Changes:
- Switch library projects to
DebugType=embeddedand removeDebugType=fullfrom the test project. - Move Extensions projects to
AnalysisLevel=latestand add additional analyzer suppressions for Extensions tests. - Reduce visibility of JSON test helper types (records) to
internalfor NET6+.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| csharp/PhoneNumbers/PhoneNumbers.csproj | Set DebugType to embedded for the main library. |
| csharp/PhoneNumbers.Test/PhoneNumbers.Test.csproj | Remove explicit DebugType=full (allowing default portable PDB behavior). |
| csharp/PhoneNumbers.Extensions/PhoneNumbers.Extensions.csproj | Set DebugType=embedded and change AnalysisLevel to latest. |
| csharp/PhoneNumbers.Extensions.Test/TestConversion.cs | Make NET6+ helper record types internal. |
| csharp/PhoneNumbers.Extensions.Test/PhoneNumbers.Extensions.Test.csproj | Add CA1812/CA1852 suppressions and change AnalysisLevel to latest. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
===========================================
+ Coverage 76.97% 97.94% +20.97%
===========================================
Files 40 40
Lines 4712 52924 +48212
Branches 1115 1115
===========================================
+ Hits 3627 51839 +48212
Misses 851 851
Partials 234 234 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wmundev
commented
May 10, 2026
wmundev
changed the title
📊 Benchmark Results
PR branch
|
| Method | Job | Runtime | PhoneNumberCount | Mean | Error | StdDev | Gen0 | Gen1 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| ParseValidateAndFormatPhoneNumbers | .NET 8.0 | .NET 8.0 | 1000 | 2.761 ms | 0.0242 ms | 0.0189 ms | 35.1563 | - | 582.48 KB |
| ParseValidateAndFormatPhoneNumbers | .NET 9.0 | .NET 9.0 | 1000 | 2.537 ms | 0.0066 ms | 0.0062 ms | 35.1563 | - | 582.48 KB |
| ParseValidateAndFormatPhoneNumbers | .NET Framework 4.8 | .NET Framework 4.8 | 1000 | 7.931 ms | 0.1560 ms | 0.1733 ms | 226.5625 | 23.4375 | 1397.64 KB |
| ParseValidateAndFormatPhoneNumbers | .NET 8.0 | .NET 8.0 | 10000 | 27.651 ms | 0.4595 ms | 0.4298 ms | 343.7500 | - | 5818.97 KB |
| ParseValidateAndFormatPhoneNumbers | .NET 9.0 | .NET 9.0 | 10000 | 26.055 ms | 0.5097 ms | 0.5665 ms | 343.7500 | - | 5818.97 KB |
| ParseValidateAndFormatPhoneNumbers | .NET Framework 4.8 | .NET Framework 4.8 | 10000 | 75.811 ms | 0.8939 ms | 0.7924 ms | 2142.8571 | 142.8571 | 13952.16 KB |
| ParseValidateAndFormatPhoneNumbers | .NET 8.0 | .NET 8.0 | 100000 | 273.487 ms | 1.0998 ms | 0.9183 ms | 3500.0000 | - | 58205.32 KB |
| ParseValidateAndFormatPhoneNumbers | .NET 9.0 | .NET 9.0 | 100000 | 263.002 ms | 5.2164 ms | 7.6461 ms | 3500.0000 | - | 58205.32 KB |
| ParseValidateAndFormatPhoneNumbers | .NET Framework 4.8 | .NET Framework 4.8 | 100000 | 839.783 ms | 14.3213 ms | 13.3961 ms | 22000.0000 | 2000.0000 | 139529.6 KB |
twcclegg
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates C# project build settings to embed debug symbols in assemblies (improving cross-platform debugging ergonomics) and adjusts analyzer configuration for the Extensions projects/tests.