feat: remove unneeded System.IO.Compression package#339
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
=======================================
Coverage 76.97% 76.97%
=======================================
Files 40 40
Lines 4712 4712
Branches 1115 1115
=======================================
Hits 3627 3627
Misses 851 851
Partials 234 234 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📊 Benchmark Results
PR branch
|
| Method | Job | Runtime | PhoneNumberCount | Mean | Error | StdDev | Gen0 | Gen1 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| ParseValidateAndFormatPhoneNumbers | .NET 8.0 | .NET 8.0 | 1000 | 2.795 ms | 0.0521 ms | 0.0535 ms | 35.1563 | - | 582.48 KB |
| ParseValidateAndFormatPhoneNumbers | .NET 9.0 | .NET 9.0 | 1000 | 2.589 ms | 0.0421 ms | 0.0394 ms | 35.1563 | - | 582.48 KB |
| ParseValidateAndFormatPhoneNumbers | .NET Framework 4.8 | .NET Framework 4.8 | 1000 | 8.091 ms | 0.1073 ms | 0.1004 ms | 218.7500 | 15.6250 | 1398.14 KB |
| ParseValidateAndFormatPhoneNumbers | .NET 8.0 | .NET 8.0 | 10000 | 28.771 ms | 0.5625 ms | 0.6908 ms | 343.7500 | - | 5818.97 KB |
| ParseValidateAndFormatPhoneNumbers | .NET 9.0 | .NET 9.0 | 10000 | 26.833 ms | 0.5238 ms | 0.6624 ms | 343.7500 | - | 5818.97 KB |
| ParseValidateAndFormatPhoneNumbers | .NET Framework 4.8 | .NET Framework 4.8 | 10000 | 85.711 ms | 1.6575 ms | 2.1552 ms | 2166.6667 | 166.6667 | 13958.84 KB |
| ParseValidateAndFormatPhoneNumbers | .NET 8.0 | .NET 8.0 | 100000 | 285.673 ms | 4.6510 ms | 4.3506 ms | 3500.0000 | - | 58205.32 KB |
| ParseValidateAndFormatPhoneNumbers | .NET 9.0 | .NET 9.0 | 100000 | 266.177 ms | 2.0484 ms | 1.7105 ms | 3500.0000 | - | 58205.32 KB |
| ParseValidateAndFormatPhoneNumbers | .NET Framework 4.8 | .NET Framework 4.8 | 100000 | 846.614 ms | 12.3099 ms | 11.5147 ms | 22000.0000 | 2000.0000 | 139529.6 KB |
twcclegg
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no need this package anymore since we use binary files now