refactor: refactor offline geocoder to use prefixmap similar to java version#334
Merged
wmundev merged 1 commit intoMay 10, 2026
Merged
Conversation
b10d976 to
158d90e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
==========================================
- Coverage 75.79% 75.63% -0.17%
==========================================
Files 40 40
Lines 4731 4712 -19
Branches 1119 1115 -4
==========================================
- Hits 3586 3564 -22
- Misses 914 917 +3
Partials 231 231 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
158d90e to
e0e6dbe
Compare
✔️ Benchmark Results
📊 Comparison vs.
|
| Method | Runtime | PhoneNumberCount | main Mean |
PR Mean | Time Δ | main Alloc |
PR Alloc | Alloc Δ | Status |
|---|---|---|---|---|---|---|---|---|---|
| ParseValidateAndFormatPhoneNumbers | .NET 8.0 | 1000 | 2.789 ms | 2.868 ms | 🟡 +2.8% | 581.63 KB | 581.63 KB | 🟡 +0.0% | 🟡 Neutral |
| ParseValidateAndFormatPhoneNumbers | .NET 8.0 | 10000 | 28.216 ms | 28.097 ms | 🟡 -0.4% | 5.67 MB | 5.67 MB | 🟡 +0.0% | 🟡 Neutral |
| ParseValidateAndFormatPhoneNumbers | .NET 8.0 | 100000 | 294.651 ms | 289.911 ms | 🟡 -1.6% | 56.73 MB | 56.73 MB | 🟡 +0.0% | 🟡 Neutral |
| ParseValidateAndFormatPhoneNumbers | .NET 9.0 | 1000 | 2.658 ms | 2.679 ms | 🟡 +0.8% | 581.63 KB | 581.63 KB | 🟡 +0.0% | 🟡 Neutral |
| ParseValidateAndFormatPhoneNumbers | .NET 9.0 | 10000 | 27.159 ms | 26.835 ms | 🟡 -1.2% | 5.67 MB | 5.67 MB | 🟡 +0.0% | 🟡 Neutral |
| ParseValidateAndFormatPhoneNumbers | .NET 9.0 | 100000 | 271.141 ms | 269.517 ms | 🟡 -0.6% | 56.73 MB | 56.73 MB | 🟡 +0.0% | 🟡 Neutral |
| ParseValidateAndFormatPhoneNumbers | .NET Framework 4.8 | 1000 | 8.025 ms | 7.886 ms | 🟡 -1.7% | 1.37 MB | 1.36 MB | 🟡 -0.0% | 🟡 Neutral |
| ParseValidateAndFormatPhoneNumbers | .NET Framework 4.8 | 10000 | 81.925 ms | 79.757 ms | 🟡 -2.6% | 13.63 MB | 13.63 MB | 🟡 +0.0% | 🟡 Neutral |
| ParseValidateAndFormatPhoneNumbers | .NET Framework 4.8 | 100000 | 809.062 ms | 827.629 ms | 🟡 +2.3% | 136.26 MB | 136.26 MB | 🟡 +0.0% | 🟡 Neutral |
📋 Full Results — PR branch
| Method | Job | Runtime | PhoneNumberCount | Mean | Error | StdDev | Gen0 | Gen1 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| ParseValidateAndFormatPhoneNumbers | .NET 8.0 | .NET 8.0 | 1000 | 2.868 ms | 11.935 μs | 44.656 μs | 6.0000 | - | 581.63 KB |
| ParseValidateAndFormatPhoneNumbers | .NET 8.0 | .NET 8.0 | 10000 | 28.097 ms | 54.650 μs | 204.481 μs | 7.0000 | - | 5.67 MB |
| ParseValidateAndFormatPhoneNumbers | .NET 8.0 | .NET 8.0 | 100000 | 289.911 ms | 1.481 ms | 6.947 ms | 4.0000 | - | 56.73 MB |
| ParseValidateAndFormatPhoneNumbers | .NET 9.0 | .NET 9.0 | 1000 | 2.679 ms | 8.871 μs | 34.357 μs | 6.0000 | - | 581.63 KB |
| ParseValidateAndFormatPhoneNumbers | .NET 9.0 | .NET 9.0 | 10000 | 26.835 ms | 66.151 μs | 247.514 μs | 7.0000 | - | 5.67 MB |
| ParseValidateAndFormatPhoneNumbers | .NET 9.0 | .NET 9.0 | 100000 | 269.517 ms | 573.196 μs | 2.067 ms | 4.0000 | - | 56.73 MB |
| ParseValidateAndFormatPhoneNumbers | .NET Framework 4.8 | .NET Framework 4.8 | 1000 | 7.886 ms | 38.580 μs | 172.536 μs | 29.0000 | 3.0000 | 1.36 MB |
| ParseValidateAndFormatPhoneNumbers | .NET Framework 4.8 | .NET Framework 4.8 | 10000 | 79.757 ms | 365.230 μs | 1.367 ms | 15.0000 | 1.0000 | 13.63 MB |
| ParseValidateAndFormatPhoneNumbers | .NET Framework 4.8 | .NET Framework 4.8 | 100000 | 827.629 ms | 3.764 ms | 14.579 ms | 22.0000 | 2.0000 | 136.26 MB |
📋 Full Results — main branch
| Method | Job | Runtime | PhoneNumberCount | Mean | Error | StdDev | Gen0 | Gen1 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| ParseValidateAndFormatPhoneNumbers | .NET 8.0 | .NET 8.0 | 1000 | 2.789 ms | 7.712 μs | 29.870 μs | 6.0000 | - | 581.63 KB |
| ParseValidateAndFormatPhoneNumbers | .NET 8.0 | .NET 8.0 | 10000 | 28.216 ms | 66.343 μs | 248.231 μs | 7.0000 | - | 5.67 MB |
| ParseValidateAndFormatPhoneNumbers | .NET 8.0 | .NET 8.0 | 100000 | 294.651 ms | 1.486 ms | 6.647 ms | 4.0000 | - | 56.73 MB |
| ParseValidateAndFormatPhoneNumbers | .NET 9.0 | .NET 9.0 | 1000 | 2.658 ms | 3.356 μs | 11.625 μs | 6.0000 | - | 581.63 KB |
| ParseValidateAndFormatPhoneNumbers | .NET 9.0 | .NET 9.0 | 10000 | 27.159 ms | 84.839 μs | 317.439 μs | 7.0000 | - | 5.67 MB |
| ParseValidateAndFormatPhoneNumbers | .NET 9.0 | .NET 9.0 | 100000 | 271.141 ms | 361.163 μs | 1.351 ms | 4.0000 | - | 56.73 MB |
| ParseValidateAndFormatPhoneNumbers | .NET Framework 4.8 | .NET Framework 4.8 | 1000 | 8.025 ms | 40.430 μs | 180.811 μs | 14.0000 | 1.0000 | 1.37 MB |
| ParseValidateAndFormatPhoneNumbers | .NET Framework 4.8 | .NET Framework 4.8 | 10000 | 81.925 ms | 344.564 μs | 1.334 ms | 15.0000 | 1.0000 | 13.63 MB |
| ParseValidateAndFormatPhoneNumbers | .NET Framework 4.8 | .NET Framework 4.8 | 100000 | 809.062 ms | 3.752 ms | 14.040 ms | 22.0000 | 2.0000 | 136.26 MB |
twcclegg
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.