Skip to content

Implemented cmake support#13

Open
ArnCarveris wants to merge 97 commits into
tuket:masterfrom
ArnCarveris:cmake-support
Open

Implemented cmake support#13
ArnCarveris wants to merge 97 commits into
tuket:masterfrom
ArnCarveris:cmake-support

Conversation

@ArnCarveris

Copy link
Copy Markdown

Hi, I've found that this project needs modern c++ support, there is list of done work to make it happen:

  • Implemented cmake support, VS2017
  • Removed dependencies source code
  • Dependency resolved via vcpkg, to save time
  • Replaced SOIL by stb_image for image loading
  • Using C++17
  • Improved & fixes forest gen script for python3
  • Implemented line ending immutability for generated & saved cells.
  • Various small fixes & improvements, using stabilized new_animation branch as basis.

Btw:. paper is written very well.

@tuket

tuket commented Jun 6, 2018

Copy link
Copy Markdown
Owner

Hey, @ArnCarveris !
Some cool changes you've made!
I'm so honored that you took the time to have a look at the code and even read the paper.
I haven't made any changes to this project in several years and I don't have any plans to do so in the future.
If you are willing to continue adding more features/fixes to this project I think it's best that you do it in your repo. I can add a link in the README of my repo refering to yours as the latest. Does it sound right?
Thank you!

@ArnCarveris

ArnCarveris commented Jun 6, 2018

Copy link
Copy Markdown
Author

@tuket I've read paper first, when I dive in code that sadly doesn't work.


My plan is to integrate my EnTT fork, tiled & raylib for 3D support on following branch: experimental/ecs.

Then I'll done implementing it, I'll do separate PR for README with link & sort description whats done(Maybe write paper for that, not sure, never done that before).


I suggest merge this PR because people needs working code with modern development environment support.

All dependence are resolved by vcpkg, now installing must be done manually, later I'll try improve this part by need.

@tuket

tuket commented Jun 8, 2018

Copy link
Copy Markdown
Owner

That's cool!
I've given it a shoot to compile. It fails in this line
work_queue.cpp:39
std::unique_lock lock(mutex);
If I change it to:
std::unique_lock<std::mutex> lock(mutex);
, then it compiles fine.

Why did you add this sleep in resouce_manager.cpp?
std::this_thread::sleep_for(1ms);

I think it's great that people will get to work in a modern environment. But since I don't want to maintain this project they can still get it from your repo.
If you want me to link to your repo just let me know :)

@ArnCarveris

Copy link
Copy Markdown
Author

@tuket

I've given it a shoot to compile.

What tool-chain you using?

Why did you add this sleep in resouce_manager.cpp?

This won't block other threads, when this thread on the high load, actually this is common practice.

But since I don't want to maintain this project they can still get it from your repo.

I'll do much more complex weird experimental changes that not on the paper.
I don't want confuse people if they just want an working code.

I understand that after years abandoned project, there actually no will came back and do something with it.
But, I may hasn't been attempted to create PR, all I wanted just contribute an fix that deserves open source sociality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants