Additional fiber output#8
Open
tuchpaul wants to merge 7 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the remodel-fiber mixture constituent output by exposing additional stretch measures (total fiber stretch, elastic stretch, and external inelastic stretch) through the Mixture::RemodelFiber API and wiring them into the constituent runtime output system.
Changes:
- Added
evaluate_current_lambda_f(),evaluate_current_lambda_e(), andevaluate_current_lambda_ext()toMixture::RemodelFiberand its internal implementation. - Implemented elastic stretch evaluation (
lambda_e) and forwarded these values through the public wrapper class. - Registered and populated three new output fields for remodel-fiber constituents:
_lambda_f,_lambda_e,_lambda_ext.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/mixture/src/4C_mixture_remodelfiber.hpp | Adds new public evaluation methods for lambda_f / lambda_e / lambda_ext. |
| src/mixture/src/4C_mixture_remodelfiber.cpp | Implements the new evaluation methods and forwards them through the public interface. |
| src/mixture/src/4C_mixture_remodelfiber-internal.hpp | Adds corresponding internal implementation method declarations. |
| src/mixture/src/4C_mixture_constituent_remodelfiber_ssi.cpp | Registers/evaluates new output quantities for SSI remodel-fiber constituents. |
| src/mixture/src/4C_mixture_constituent_remodelfiber_impl.cpp | Registers/evaluates new output quantities for implicit remodel-fiber constituents. |
| src/mixture/src/4C_mixture_constituent_remodelfiber_expl.cpp | Registers/evaluates new output quantities for explicit remodel-fiber constituents. |
| { | ||
| return states_.back().lambda_f / | ||
| (states_.back().lambda_r * | ||
| states_.back().lambda_ext); // lambda_e = lambda_f / lambda_r * lambda_ext |
Comment on lines
142
to
+147
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_sig"] = 1; | ||
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_growth_scalar"] = 1; | ||
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_lambda_r"] = 1; | ||
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_lambda_f"] = 1; | ||
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_lambda_e"] = 1; | ||
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_lambda_ext"] = 1; |
Comment on lines
190
to
+195
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_sig"] = 1; | ||
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_growth_scalar"] = 1; | ||
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_lambda_r"] = 1; | ||
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_lambda_f"] = 1; | ||
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_lambda_e"] = 1; | ||
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_lambda_ext"] = 1; |
Comment on lines
228
to
+233
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_sig"] = 1; | ||
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_growth_scalar"] = 1; | ||
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_lambda_r"] = 1; | ||
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_lambda_f"] = 1; | ||
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_lambda_e"] = 1; | ||
| names_and_size["mixture_constituent_" + std::to_string(id()) + "_lambda_ext"] = 1; |
…hmark-test-report
- add nodiscard where reasonable - improve doxygen documentation - remove unnecessary breaks
function framework
…m-implemented-functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.