Support globs for src and ignoring paths#165
Conversation
aperkaz
changed the title
aperkaz
changed the title
aperkaz
changed the title
| "jest": "^30.2.0", | ||
| "lint-staged": "^5.0.0", | ||
| "prettier": "^1.19.1", | ||
| "ts-jest": "^26.3.0", | ||
| "ts-jest": "^29.4.6", | ||
| "ts-node": "3.3.0", | ||
| "typescript": "^3.9.7" | ||
| "typescript": "^4.3" |
There was a problem hiding this comment.
These may be good changes, but they are strictly unrelated.
There was a problem hiding this comment.
As mentioned in the description, the glob package required a higher version of typescript, thus creating a chain reaction that required updating jest too.
There was a problem hiding this comment.
Ugh... I would personally prefer dependency bumps to be a separate PR, but then again I'm not the owner of this project, maybe they think it's OK.
There was a problem hiding this comment.
I see the value of splitting it into multiple PRs but would appreciate the input of someone with merge and publish privileges.
If you have the rights @dimaqq, I will get right into it 🙂
|
I suppose I can try to make a separate PR for the Jest defaults update. |
|
Deps update done in #167, PTAL. |
|
Guys, thank you for your contributions. I will take a closer look ASAP. |
|
@aperkaz would you be up to rebasing this PR or cherry-picking only the glob changes and new tests? |
aperkaz
force-pushed
the
feat/glob-and-ignore
branch
from
49d9d2f to
ae870eb
Compare
|
@dimaqq I accidentally closed the PR, sorry about the noise. |
Includes internal refactor to align argument names with CLI flag naming
Internal refactor to align argument names with CLI flag naming
aperkaz
force-pushed
the
feat/glob-and-ignore
branch
from
0483d9c to
312c129
Compare
|
awesome work, thanks for your contribution! Your changes are present in @dimaqq - big thanks for the review ❤️ |
| "node_modules/@isaacs/cliui": { | ||
| "version": "8.0.2", | ||
| "resolved": "https://registry.npmjs.org/@isaacs/cliui/-/cliui-8.0.2.tgz", | ||
| "resolved": "https://registry.npmmirror.com/@isaacs/cliui/-/cliui-8.0.2.tgz", |
There was a problem hiding this comment.
I wonder if perhaps this (and many below) is an unnecessary change.
registry.npmmirror.com should be legit and has some use: for developers based in China. this file had a mix of npmjs.org and this mirror before the change, so there was precedent but also... I feel that the specific mirror should be individual developer's concern, not a project-level concern.
There was a problem hiding this comment.
Good point, the package-lock.json was auto-generated when running npm i for the new packages. I am based in europe, so probably my .npmrc is to blame.
Will take it into consideration in the future 🙂
There was a problem hiding this comment.
No worries, I have fixed that after the merge
3 participants
This PR is a proposal for adding glob and ignore capabilities to the ttag-cli while keeping backwards compatibility (#78).
Feedback is welcome! 🙂
The feature has been built around the following goals:
Change summary:
globpackage requires a higher version oftypescript, thus creating a chain reaction that required updatingjesttoo).jestversion bump.src/index.tsto inject theignoreargument into thecommands/*.src/libs/utils.ts > resolvePaths. No changes were made to the existing file-walking logic.